337304 - Right clicking followed by middle clicking results in misplaced autoscroll cursor.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Prameet Shah]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060404 SeaMonkey/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060404 SeaMonkey/1.0.1

Right clicking followed by middle clicking results in misplaced autoscroll cursor.    When this happens and you still hold down the middle key button, you can autoscroll at the same time you can go through the context menu.

Reproducible: Always

Steps to Reproduce:
1. Go to any website
2. Click and hold down right button
3. Click and hold down middle button
4. Release right button

Actual Results:  
Autoscroll indicator jumps, and context menu doesn't go away

Expected Results:  
The menu and the autoscroll should go away, if similar to IE and Firefox.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Confirming Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060404 SeaMonkey/1.0.1

Comment 2

[Prameet Shah]

Changing utilityOverlay.js to use "window." instead of "document." at line 573 seems to fix the bug.

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 221466 [details] [diff] [review]
patch

Hmmm.. this causes bad things.  Will have to figure out another way.

Comment 5

[[e-mail]]

Perhaps if we add contextmenu as one of the autoscrollpopup dismissal events?

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #5)
> Perhaps if we add contextmenu as one of the autoscrollpopup dismissal events?
> 

Will that get the normal contextmenu to disappear properly?  The context menu you get when doing the steps to reproduce doesn't go away when you left click somewhere else.

Comment 7

[jag (Peter Annema)]

So the steps are:

1. press down the right mouse button (and hold)
2. press down the middle mouse button (and hold)
3. release the right mouse button

At this point you should have a context menu and the autoscroll cursor (its offset from the mouse pointer is the offset from the content area's top-left to the screen's top-left).

4. release the middle mouse button

At this point the context menu remains and you can't dismiss it by left-clicking outside it. Right-clicking somewhere outside it to bring up a new context menu, or clicking on any of the items in the context menu will dismiss it (and in the right-click case bring up a new context menu).

Can we disable the autoscroll stuff when the right mouse button is pressed? Or would this interfere with systems where left+right mouse button acts as a simulated middle mouse click?

Comment 8

[jag (Peter Annema)]

Oh, I missed those steps to reproduce from Prameet's initial comment. Silly me. My step four is an additional step + result that CTho pointed out.

Comment 9

[[e-mail]]

(In reply to comment #6)
>(In reply to comment #5)
>>Perhaps if we add contextmenu as one of the autoscrollpopup dismissal events?
>Will that get the normal contextmenu to disappear properly?
My guess is that the issue is caused by opening two unrelated popups simultaneously (I think layout code assumes that only popups in an ancestor relationship will be open simultaneously), so by dismissing the autoscroll popup before the context menu can open we will avoid the layout confusion.

Comment 10

[jag (Peter Annema)]

I guess that would do the trick too.

Comment 11

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

This gets the autoscroll popup to go away, and results in the context menu disappearing properly when you left-click elsewhere.

Comment 12

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checking in mozilla/xpfe/communicator/resources/content/utilityOverlay.js;
/cvsroot/mozilla/xpfe/communicator/resources/content/utilityOverlay.js,v  <--  u
tilityOverlay.js
new revision: 1.94; previous revision: 1.93
done

Comment 13

[Robert Kaiser]

Comment on attachment 222860 [details] [diff] [review]
patch

a=me for SeaMonkey 1.1

Comment 14

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checked in on 1.8 branch