337390 - Session restore dialog is scary / confusing

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Ryan Flint [:rflint] (ping via IRC for reviews)]

In its current form, the session restore dialog has the potential to be a bit scary/confusing to the average user wondering where their previous browser session went. A few ideas were tossed around on IRC, and a little rewording of the main text and [Cancel] button were viewed to be a Good Thing(tm).

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Possible change

Comment 2

[Simon Bünzli]

AFAIK it was planned to replace this simple dialog with something more elaborate for beta 1. Should that not be the case, I'd additionally to reword the Cancel button also move it to where it's rather expected: to the right on Windows resp. to the left on OS X/Gnome.

Comment 3

[Mike Schroepfer]

Beltzner can we get some love on the SR Dialog?

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 221549 [details] [diff] [review]
Possible change

This is better phrasing and the new button label is better, too. Couple of nits:

1) Entity needs to be changed (suggest restoredText).

2) There's a comma splice in there - the second comma should be removed (s/problems, you/problems you)

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Ryan, if you could work up a new patch, carry over the ui-r+ and request review from me, we can try to get this landed on trunk ASAP.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

(oops, undoing my clobber)

Comment 7

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch v2

Sorry for the delay, this one got lost during a deluge of bugmail.

Comment 8

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch v3

Whoops, it helps to save the edited file before diffing ;)

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Bah, reed points out that we're missing a conjunction, and the blighter's right, at that. Then there was a friggin' 20 minute iterative debate, before we got to:

restoreTitle= %S - Restore Previous Session 

restoredText=%S experienced a serious error, and your last session closed unexpectedly. You can restore the tabs and windows from your previous session, or start a new session if the problem continues.

Also, the default button (which should be the right-most button) on OS X is "Start New Session", and it should be "Restore Session".

Comment 10

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch v4

New text + button defaults/positioning fixup.

Comment 11

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Roll in changes from bug 342765

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/sessionstore/src/nsSessionStartup.js 	1.5
mozilla/browser/locales/en-US/chrome/browser/sessionstore.properties 	1.2

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 227833 [details] [diff] [review]
Roll in changes from bug 342765

>-restoreTitle= %S - Session Restore 
>-restoreText=%S has recovered from a serious error.  One of the pages you were viewing may have caused the problem, so you may experience further problems if you continue with the previous browsing session.
>+restoreTitle= %S - Restore Previous Session 
>+restoredText=%S experienced a serious error, and your last session closed unexpectedly. You can restore the tabs and windows from your previous session, or start a new session if the problem continues.

Should you be renaming the keys here so that localizers know they need to re-translate?

Comment 14

[Reed Loden [:reed]]

(In reply to comment #13)
> Should you be renaming the keys here so that localizers know they need to
> re-translate?

restoreText has been renamed to restoredText, but the title name has been left the same.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 227833 [details] [diff] [review]
Roll in changes from bug 342765

Please do land this on the branch, but change the name of restoreTitle to restoredTitle in both nsSessionStartup.js and sessionstore.properties.

Comment 16

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: 1.8 Branch Patch

Branch version of the above patch with the entity name change.

Comment 17

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/sessionstore/src/nsSessionStartup.js 	1.2.2.4
mozilla/browser/locales/en-US/chrome/browser/sessionstore.properties 	1.1.2.3

Comment 18

[:Gavin Sharp [email: [e-mail]]]

I landed the entity changes (restoreTitle->restoredTitle) on the trunk.
mozilla/browser/components/sessionstore/src/nsSessionStartup.js 	1.6
mozilla/browser/locales/en-US/chrome/browser/sessionstore.properties 	1.3

Comment 19

[Muddassir]

It is really scary. first of all I dont want to click an additional button before starting browsing.
Secondly if the firefox crashes and I was browsing something private, my family members can figure out what I was browsing.

It really need to be removed.