337432 - xml special characters need to be escaped in description and title bar

Status: RESOLVED FIXED

(Other Applications :: CCK, defect)

Description

[webograph]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.0.3) Gecko/20060426 (CK-VereinLOK) Firefox/1.5.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.0.3) Gecko/20060426 (CK-MyComp) Firefox/1.5.0.3

if you enter xml special charakters like < in the cck package description or the custom title bar text, they are not handled properly. everything works fine if you escape them the xml way, but this should at least be pointed out.

Reproducible: Always

Steps to Reproduce:
1. include a < in the description string
2. make extension
3. firefox will refuse to install it because "it is not compatible".

1. include a < in the browser title string
2. make extension
3. install it
4. run fx: an xml error message will appear below the browser window



Expected Results:  
<, > and & should be escaped; at least there should be a message that warns the user to escape these.

additionally, when using non-ascii characters in the package description (german umlauts, for example), these won't show up correctly in the package description. observed on a german (austrian) windows xp installation without any particular settings (didn't even set default char encoding to utf8, as i usually do)

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Fix for install.rdf problem

Here's a fix to make install.rdf take i18n chars - I wasn't using a character converter output stream.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: The rest of the fix

Add entity replacement for:

name
description
creator's name
title bar text
tool tip
help menu

I think this should cover it

Comment 3

[Mike Kaply [:mkaply]]

Fix checked in.