There is a mismatch between "single cert lookup" and "multi cert lookup" functions: - PK11_FindCertFromNickname - PK11_FindCertsFromNickname "Single cert" function PK11_FindCertFromNickname has an additional section which is prefixed by the following comment: "if it wasn't found, repeat the process for email address" "Multi cert" function PK11_FindCertsFromNickname does NOT contain a corresponding section. In my test scenario, when querying an email address using FindCert, one cert was returned. However, FindCerts returned zero certs. I think this is an obvious inconsistency and should be fixed. This fix will be required for bug 337430.
Created attachment 221624 [details] [diff] [review] Patch v1 This added code is an exact copy of the corresponding section in the FindCert function. (But I adjusted the name of one variable)
Let's try to get this into 3.11.2
Target Milestone: --- → 3.11.2
Comment on attachment 221624 [details] [diff] [review] Patch v1 I doubt it will make 3.11.2. Kai, if you need quicker response on reviews be sure to CC other NSS developers. I'd like julien to eyeball this before it goes into a 3.11 branch. bob
Comment on attachment 221624 [details] [diff] [review] Patch v1 Looks OK, very close to what the individual cer lookup function does.
Attachment #221624 - Flags: superreview?(julien.pierre.bugs) → superreview+
fixed on NSS tip
new cvs tip rev was 1.152 now fixed on 3.11 branch, too Checking in pk11cert.c; /cvsroot/mozilla/security/nss/lib/pk11wrap/pk11cert.c,v <-- pk11cert.c new revision: 220.127.116.11; previous revision: 18.104.22.168 done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.