337486 - mismatch between PK11_FindCertFromNickname and FindCerts

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Kai Engert [:KaiE:]]

There is a mismatch between "single cert lookup" and "multi cert lookup" functions:
- PK11_FindCertFromNickname
- PK11_FindCertsFromNickname

"Single cert" function PK11_FindCertFromNickname
has an additional section which is prefixed by the following comment:
  "if it wasn't found, repeat the process for email address"

"Multi cert" function PK11_FindCertsFromNickname
does NOT contain a corresponding section.

In my test scenario, when querying an email address using FindCert, one cert was returned.
However, FindCerts returned zero certs.

I think this is an obvious inconsistency and should be fixed.
This fix will be required for bug 337430.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Patch v1

This added code is an exact copy of the corresponding section in the FindCert function. (But I adjusted the name of one variable)

Comment 2

[Kai Engert [:KaiE:]]

Let's try to get this into 3.11.2

Comment 3

[Robert Relyea]

Comment on attachment 221624 [details] [diff] [review]
Patch v1

I doubt it will make 3.11.2.
Kai, if you need quicker response on reviews be sure to CC other NSS developers.

I'd like julien to eyeball this before it goes into a 3.11 branch.

bob

Comment 4

[Julien Pierre]

Comment on attachment 221624 [details] [diff] [review]
Patch v1

Looks OK, very close to what the individual cer lookup function does.

Comment 5

[Kai Engert [:KaiE:]]

fixed on NSS tip

Comment 6

[Kai Engert [:KaiE:]]

new cvs tip rev was 1.152

now fixed on 3.11 branch, too

Checking in pk11cert.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11cert.c,v  <--  pk11cert.c
new revision: 1.143.2.8; previous revision: 1.143.2.7
done