337528 - Make cached prototypes work with splitwindows

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect, P2)

Description

[Blake Kaplan (:mrbkap) (inactive)]

The cached prototype stuff (or whatever we ended up calling it!) doesn't work with splitwindows. We need to fix that.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Note: This bug will also turn JSCLASS_IS_ANONYMOUS back on for the call class.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Shell testing code

For easier testing of splitwindow/innerObject-outerObject stuff, I've implemented this splitwindow-like thing in the JS shell.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

The answer is that cx->classObjects loses. Using hidden properties is the way to go. I'll try to patch this tomorrow.

Comment 4

[Brendan Eich [:brendan]]

Attachment: Make Call's class be anonymous again

r=mrbkap, he just said.

/be

Comment 5

[James Ross]

This is fallout from bug 304376, right? Could we have a dependency chain if so?

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

I think this bug was fixed by other checkins, please reopen if this isn't the case.

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 221757 [details] [diff] [review]
Shell testing code

split_ instead of complex_

setup_complex => split_setup

Break multiline conditions after ||

rs=me in any event.

/be