337571 - Fix the inability to edit keywords on folders in the outline view

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We don't allow folders to have keywords, so the keyword field in the Folder view of the info panel should be disabled.

Right now it's not in the tab loop, but you can still click there, add a keyword, and watch it be discarded when you leave the field :P

We should disable the field entirely (and maybe make the label grey?) until such time as we actually support keywords for folders/tab groups, if ever (I thought there was a bug, but I can't find it).

Blocking bug 325880 because this *is* just a .nib change :)

Comment 1

[Stuart Morgan]

Huh? Folders and tab groups can have keywords. I have lots, and they work fine.

Comment 2

[Stuart Morgan]

There is a sort of opposite bug though:
http://lxr.mozilla.org/mozilla/source/camino/src/bookmarks/BookmarkOutlineView.mm#93
prevents editing the keyword of a folder from the table view, and should be removed.

Comment 3

[Chris Lawson (gone)]

What Stuart said. Someone remind me tonight and I'll get a patch in for comment 2 if no one else has done it by then.

cl

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Hrm; I tried to add keywords to folders and tab groups both last night, and they were discarded as soon as I left the field.  Stuart, have you tried adding keywords to folders recently?  Maybe something's regressed?

At any rate, we should fix comment 2 *and* fix the Info nib to 1) include the keyword field in the tab loop and 2) not discard the keywords ;)

Comment 5

[Chris Lawson (gone)]

Smokey's Camino might be on crack. I can add keywords successfully to both tab groups and folders using the 08 May trunk nightly, *and* the keyword field is in the tab chain of the info window.

cl

Comment 6

[Chris Lawson (gone)]

Attachment: fixes the inability to edit keywords on folders in the outline view

Comment 7

[Chris Casciano]

Camino 1.0.1 / OS X 10.3.9


here's what I seem to be able to do at first glance 

from the main bookmarks view I can edit keywords on individual items and tabgroups, but not normal folders (or spacers)

from the info window I can also add a keyword to folders that aren't tabgroups. using the keyword from the location bar makes them work like tabgroups

I don't see any behavior where text entered dissapears or flickers.. the items I can't edit in the view never turned a click into the text input area

Comment 8

[Stuart Morgan]

Comment on attachment 221773 [details] [diff] [review]
fixes the inability to edit keywords on folders in the outline view

Yup. r=me.

My old 2006032900 (1.0+) has none of Smokey's issues.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 221773 [details] [diff] [review]
fixes the inability to edit keywords on folders in the outline view

sr=pink

Comment 10

[Mike Pinkerton (not reading bugmail)]

fixed trunk and branch