Closed
Bug 337833
Opened 19 years ago
Closed 19 years ago
Menu Separators in the Bookmark Bar are focusable with Full Keyboard Access on
Categories
(Camino Graveyard :: Toolbars & Menus, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: hwaara)
Details
(Keywords: fixed1.8.1, polish)
Attachments
(1 file)
|
1.54 KB,
patch
|
bugzilla-graveyard
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
If you have menu separators in your Bookmark Bar, they're focusable when Full Keyboard Access on, even though you can't do anything with them. They shouldn't be focusable (separators in the main toolbar are not).
|
Assignee | |
Comment 1•19 years ago
|
||
Let only bookmark buttons that are not separators accept first responder.
I moved isSeparator up to the BookmarkItem class (which BookmarkFolder inherits from), so BookmarkFolders will respond NO by default.
Attachment #221902 -
Flags: review?(bugzilla)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 221902 [details] [diff] [review]
Fix
r=me. Requesting a second r from smorgan.
cl
Attachment #221902 -
Flags: review?(stuart.morgan)
Attachment #221902 -
Flags: review?(bugzilla)
Attachment #221902 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #221902 -
Flags: review?(stuart.morgan) → superreview?(sfraser_bugs)
|
||
Updated•19 years ago
|
Attachment #221902 -
Flags: superreview?(sfraser_bugs) → superreview+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed on trunk&branch.
You need to log in
before you can comment on or make changes to this bug.
Description
•