Closed Bug 337841 Opened 18 years ago Closed 18 years ago
rv checked uninitialized in XULSort
Service Impl::Insert Container Node
valgrind complains about "Conditional jump or move depends on uninitialised value(s)". The regression is from bug 329677
Comment on attachment 221909 [details] [diff] [review] set it first D'oh!
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
We need this on the branches too. Bug 329677 landed in 126.96.36.199 and 1.8.1. "rv" is not uninitialized there, but it's definitely not being set from the GetUnicodeResource call....
Comment on attachment 221909 [details] [diff] [review] set it first a=me for the 1.8 branch. Drivers, this is a regression from a patch we took in 188.8.131.52 that could lead to crashes as far as I can tell... So we probably want to take this in 184.108.40.206 if there's any way to do that. If not, we should definitely take this in 220.127.116.11. The patch is very very safe.
We'll take it for 18.104.22.168 if we're respinning, otherwise 22.214.171.124 -- leaving in nominated limbo for now.
Flags: blocking1.8.1? → blocking1.8.1+
Comment on attachment 221909 [details] [diff] [review] set it first not respinning 126.96.36.199
Comment on attachment 221909 [details] [diff] [review] set it first approved for 1.8.0 branch, a=dveditz for drivers
Attachment #221909 - Flags: approval188.8.131.52? → approval184.108.40.206+
Fixed for 220.127.116.11.
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.