Closed Bug 337841 Opened 18 years ago Closed 18 years ago

rv checked uninitialized in XULSortServiceImpl::InsertContainerNode

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ajschult784, Assigned: ajschult784)

References

(
URL
)

Details

(Keywords: fixed1.8.1, regression, verified1.8.0.5)

Attachments

(1 file)

set it first
1.03 KB, patch
neil
: review+
neil
: superreview+
bzbarsky
: approval-branch-1.8.1+
dveditz
: approval1.8.0.5+
Details | Diff | Splinter Review 
valgrind complains about "Conditional jump or move depends on uninitialised value(s)".  The regression is from bug 329677
Attached patch set it first — — Splinter Review 

        Attachment #221909 -
        Flags: superreview?(neil)

        Attachment #221909 -
        Flags: review?(neil)

    
    

    
  
Comment on attachment 221909 [details] [diff] [review]
set it first

D'oh!

        Attachment #221909 -
        Flags: superreview?(neil)

        Attachment #221909 -
        Flags: superreview+

        Attachment #221909 -
        Flags: review?(neil)

        Attachment #221909 -
        Flags: review+

    
    

    
  
fixed
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
We need this on the branches too.  Bug 329677 landed in 1.8.0.4 and 1.8.1.  "rv" is not uninitialized there, but it's definitely not being set from the GetUnicodeResource call....
Blocks: 329677
Flags: blocking1.8.1?
Flags: blocking1.8.0.5?
Flags: blocking1.8.0.4?

    
    

    
  
Comment on attachment 221909 [details] [diff] [review]
set it first

a=me for the 1.8 branch.  Drivers, this is a regression from a patch we took in 1.8.0.4 that could lead to crashes as far as I can tell...  So we probably want to take this in 1.8.0.4 if there's any way to do that.  If not, we should definitely take this in 1.8.0.5.  The patch is very very safe.

        Attachment #221909 -
        Flags: approval1.8.0.5?

        Attachment #221909 -
        Flags: approval1.8.0.4?

        Attachment #221909 -
        Flags: approval-branch-1.8.1+

    
    

    
  
We'll take it for 1.8.0.4 if we're respinning, otherwise 1.8.0.5 -- leaving in nominated limbo for now.
Flags: blocking1.8.1? → blocking1.8.1+

    
  
Keywords: fixed1.8.1

    
    

    
  
Comment on attachment 221909 [details] [diff] [review]
set it first

not respinning 1.8.0.4

        Attachment #221909 -
        Flags: approval1.8.0.4?
Flags: blocking1.8.0.5?
Flags: blocking1.8.0.5+
Flags: blocking1.8.0.4?

    
    

    
  
Comment on attachment 221909 [details] [diff] [review]
set it first

approved for 1.8.0 branch, a=dveditz for drivers

        Attachment #221909 -
        Flags: approval1.8.0.5? → approval1.8.0.5+

    
    

    
  
Fixed for 1.8.0.5.
Keywords: fixed1.8.0.5

    
    

    
  
v.fixed on 1.8.0 branch by code inspection.
Keywords: fixed1.8.0.5 → verified1.8.0.5

    
  
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets

          You need to log in
          before you can comment on or make changes to this bug.