model > * > submission makes submit crash

RESOLVED FIXED

Status

Core Graveyard
XForms
--
critical
RESOLVED FIXED
11 years ago
10 months ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

({fixed1.8.0.5, fixed1.8.1})

Trunk
fixed1.8.0.5, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

1.07 KB, patch
Doron Rosenberg (IBM)
: review+
aaronr
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
nsXFormsSubmissionElement::Submit() forgets null-check the rv of GetModel(), so inserting any element in between model and submission makes us crash.
(Assignee)

Comment 1

11 years ago
Created attachment 222027 [details] [diff] [review]
Patch
Assignee: aaronr → allan
Status: NEW → ASSIGNED
Attachment #222027 - Flags: review?(doronr)

Updated

11 years ago
Attachment #222027 - Flags: review?(doronr) → review+
(Assignee)

Updated

11 years ago
Attachment #222027 - Flags: review?(aaronr)

Updated

11 years ago
Attachment #222027 - Flags: review?(aaronr) → review+
(Assignee)

Comment 2

11 years ago
Fixed on trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.5
(Assignee)

Updated

11 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.