27.72 KB, patch
|Details | Diff | Splinter Review|
AFAICS the tryToClose methods are only needed at shutdown. But for this case Toolkit introduced the quit-application-requested global notification. Is there any reason for not getting rid of tryToClose and only rely on the notification?
Created attachment 223363 [details] [diff] [review] replace tryToClose with "quit-application-request" Since this touches several source modules, who else should review this patch?
BTW: This patch should prevent SessionStore from losing window data if an extension calls nsIAppStartup::Quit without calling canQuitApplication.
(In reply to comment #2) > BTW: This patch should prevent SessionStore from losing window data if an > extension calls nsIAppStartup::Quit without calling canQuitApplication. Looks like this is what happened to the "Restart Firefox extension" (https://addons.mozilla.org/en-US/firefox/addon/1249). I've told the author about it.
With the removal of nsCloseAllWindows.js, the relevant code has taken a different path. -> WONTFIX