Get rid of the tryToClose pseudo-API

RESOLVED WONTFIX

Status

()

Toolkit
Startup and Profile System
--
minor
RESOLVED WONTFIX
12 years ago
10 years ago

People

(Reporter: Simon Bünzli, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
AFAICS the tryToClose methods are only needed at shutdown. But for this case Toolkit introduced the quit-application-requested global notification. Is there any reason for not getting rid of tryToClose and only rely on the notification?
(Reporter)

Comment 1

12 years ago
Created attachment 223363 [details] [diff] [review]
replace tryToClose with "quit-application-request"

Since this touches several source modules, who else should review this patch?
Attachment #223363 - Flags: first-review?(mconnor)
(Reporter)

Comment 2

12 years ago
BTW: This patch should prevent SessionStore from losing window data if an extension calls nsIAppStartup::Quit without calling canQuitApplication.
(Reporter)

Updated

11 years ago
Attachment #223363 - Flags: first-review?(mconnor)
(Reporter)

Updated

11 years ago
Depends on: 386002

Comment 3

11 years ago
(In reply to comment #2)
> BTW: This patch should prevent SessionStore from losing window data if an
> extension calls nsIAppStartup::Quit without calling canQuitApplication.

Looks like this is what happened to the "Restart Firefox extension" (https://addons.mozilla.org/en-US/firefox/addon/1249). I've told the author about it.
(Reporter)

Comment 4

10 years ago
With the removal of nsCloseAllWindows.js, the relevant code has taken a different path. -> WONTFIX
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WONTFIX

Updated

10 years ago
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup
You need to log in before you can comment on or make changes to this bug.