338167 - Localizability issues with recurNthWeek and recurLast in dateFormat.properties

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Marek Stępień [:marcoos, inactive]]

The way recurNthWeek and recurLast messages are constructed is troublesome for languages where grammatical gender of weekday names is varied.

For example, in Polish (with diacritics removed, since UTF8 at Bugzilla sucks):

"Monday" is "poniedzialek" - grammatical gender: masculine
"Sunday" is "niedziela" - grammatical gender: feminine

Also, for different grammatical genders, adjectives like "Last" and numerals like "First" or "Third" are varied for different genders:

First Monday - pierwsz_y_ poniedzialek
First Sunday - pierwsz_a_ niedziela

Last Monday - ostatni poniedzialek
Last Sunday - ostatni_a_ niedziela

So, when messages are constructed like this:

recurNthWeek=%1$S %2$S of the month

where %1 and %2 are substitued for ordinal.name.XXX and day.XXX.name, we can only get one form, while at least two (or more for languages other than Polish) are needed.

For example:

recurNthWeek=%1$S %2$S miesiaca

for number 1 gives us:

Mon: Pierwszy poniedzialek miesiaca - CORRECT
Tue: Pierwszy wtorek miesiaca  - CORRECT
Wed: Pierwszy sroda miesiaca - INCORRECT (should be: Pierwsza sroda miesiaca)
Thu: Pierwszy czwartek miesiaca  - CORRECT
Fri: Pierwszy piatek miesiaca  - CORRECT
Sat: Pierwszy sobota miesiaca - INCORRECT (should be: Pierwsza sobota miesiaca)
Sun: Pierwszy niedziela miesiaca - INCORRECT (should be: Pierwsza niedziela miesiaca)

Languages that are suffering from this may include all Slavic languages (pl, cs, sk, ru etc.) and probably others.

Comment 1

[Marek Stępień [:marcoos, inactive]]

CC'ing Pike.

Comment 2

[Axel Hecht [:Pike]]

I don't have a really good suggestion here, other than doing 7 different strings.

Comment 3

[Marek Stępień [:marcoos, inactive]]

Calendar is getting more painful to localize each day... 

Another non-localizable dtd has been checked in:
mozilla/calendar/locales/en-US/chrome/prototypes/sun-calendar-event-dialog.dtd

This has the same issues as this bug describes plus a few more. A proper acronym for this would be "FUMTU".

Comment 4

[Joey Minta]

(In reply to comment #3)
> Another non-localizable dtd has been checked in:
> mozilla/calendar/locales/en-US/chrome/prototypes/sun-calendar-event-dialog.dtd
The localization of prototypes is the responsibility of the person(s) implementing the prototype.  This code is expected to change quickly, and may or may not be localizable at a particular point in time.  The original bug, about core/shipping code that's not localizable blocks 0.3.

Comment 5

[Marek Stępień [:marcoos, inactive]]

So, the stuff in prototypes/* is not shipping?

Comment 6

[Simon Paquet [:sipaq]]

(In reply to comment #5)
> So, the stuff in prototypes/* is not shipping?

According to http://wiki.mozilla.org/Calendar:Status_Meetings:2006-07-19 this stuff will be switched off by default.

Comment 7

[Joey Minta]

Attachment: individual strings

It sucks, but I don't see another option besides individual strings here.

Comment 8

[Stefan Sitter [:ssitter]]

Comment on attachment 231811 [details] [diff] [review]
individual strings

>Index: calendar/locales/en-US/chrome/calendar/dateFormat.properties
>===================================================================
>+recur.first.sunday = First Sunday of the month
>+recur.second.sunday = Second Sunday of the month
>+recur.third.sunday = Third Sunday of the month
>+recur.fourth.sunday = Fourth Sunday of the month
>+recur.fifth.sunday = Fifth Sunday of the month
>+recur.last.sunday = Last Sunday of the month
>+recur.first.monday = First Monday of the month
>+recur.second.monday = Second Monday of the month
>+recur.third.monday = Third Monday of the month
>+recur.fourth.monday = Fourth Monday of the month
>+recur.fifth.monday = Fifth Monday of the month
>+recur.last.monday = Last Monday of the month
>+recur.first.tuesday = First Tuesday of the month
>+recur.second.tuesday = Second Tuesday of the month
>+recur.third.tuesday = Third Tuesday of the month
>+recur.fourth.tuesday = Fourth Tuesday of the month
>+recur.fifth.tuesday = Fifth Tuesday of the month
>+recur.last.tuesday = Last Tuesday of the month
...

Nit: Please add a blank line after each day block (sunday, monday, ...) to improve readability of that file.
r=ssitter

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 231811 [details] [diff] [review]
individual strings

r=mvl

Comment 10

[Joey Minta]

patch checked in.