338180 - Make tabbrowser's ".browsers" property faster

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Neil mentioned on IRC that we access this.browsers in loops, and currently build the array each time in the getter.  Jag seems to think we should cache the array after it's built.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: something like this?

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: better patch

I left out a small detail in the previous version.

Comment 3

[jag (Peter Annema)]

Comment on attachment 222239 [details] [diff] [review]
better patch

I think I'd prefer

  if (!this._browsers) {
    ...
    this._browsers = browsers;
  }
  return this._browsers;

but other than that, yeah, that should do the trick.

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: single exit point

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 222351 [details] [diff] [review]
single exit point

<jag> r+sr=jag then
<jag> Oooh, get Neil's sr
<CTho> NeilAway: the SR question was about bug 338180
<NeilAway> CTho: but if it's the .browser cache, sr=me

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checked in.

Comment 7

[Robert Kaiser]

Comment on attachment 222351 [details] [diff] [review]
single exit point

a=me for SeaMonkey 1.1

Comment 8

[Bryan]

Would this apply to FF?  Would it improve perf?

~B

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #8)
> Would this apply to FF?
Yes

> Would it improve perf?
Probably not enough to notice, but it should still be done.