338263 - instance() function should return empty nodeset on invalid instances

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Allan Beaufour]

Right now we fail if the instance() function points to an invalid instance (bug 321876). I believe we should "fail" more gracefully, and return the empty node-set.

"In all other cases, an empty node-set is returned."
[http://www.w3.org/TR/2006/REC-xforms-20060314/slice7.html#fn-instance]

Comment 1

[Allan Beaufour]

Attachment: Patch

Comment 2

[aaronr]

Comment on attachment 222321 [details] [diff] [review]
Patch

>? semantic.cache
>? xf.patch
>Index: txXFormsFunctionCall.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/content/xslt/src/xpath/txXFormsFunctionCall.cpp,v
>retrieving revision 1.10
>diff -u -p -U8 -r1.10 txXFormsFunctionCall.cpp
>--- txXFormsFunctionCall.cpp	6 Apr 2006 06:12:24 -0000	1.10
>+++ txXFormsFunctionCall.cpp	17 May 2006 08:30:44 -0000
>@@ -1,9 +1,9 @@
>-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
>+/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */

never seen this type of change before.  Intentional?

Comment 3

[Allan Beaufour]

(In reply to comment #2)
> >--- txXFormsFunctionCall.cpp	6 Apr 2006 06:12:24 -0000	1.10
> >+++ txXFormsFunctionCall.cpp	17 May 2006 08:30:44 -0000
> >@@ -1,9 +1,9 @@
> >-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
> >+/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> 
> never seen this type of change before.  Intentional?

Yes, that's the actual style used in the file, so I got tired of Emacs not following that :)

Comment 4

[Allan Beaufour]

Fixed on trunk.

Comment 5

[Allan Beaufour]

Comment on attachment 222321 [details] [diff] [review]
Patch

This only influences XForms, so it should be harmless.

Comment 6

[Allan Beaufour]

(In reply to comment #4)
> Fixed on trunk.

Ooops, tree was closed :(

Comment 7

[Allan Beaufour]

Fixed on trunk. Checked in on open tree this time...

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 222321 [details] [diff] [review]
Patch

approved for 1.8.0 branch, a=dveditz for drivers

Comment 9

[Doron Rosenberg (IBM)]

checked into 1.8.0.5

Comment 10

[aaronr]

checked into 1.8 branch

Comment 11

[Reed Loden [:reed]]

Any reason why is this bug still open?
Comments seem to show this fix has been committed to the trunk, 1.8, and 1.8.0 branches.

Comment 12

[aaronr]

Doh!  Forgot to close it.  Thanks for the heads up!