338281 - SVG drawing doesn't work anymore as expected

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase, in which it is possible to draw red lines by doing mousedown/mousemove/mouseup.
This is still working, but currently, the drawing doesn't survive a resize of the window, it gets deleted.
Also, I get a lot of js erros now in the console:
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMSVGPathElement.setAttribute]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///C:/Documents%20and%20Settings/mw22/Bureaublad/svg.htm :: domousemove :: line 33"  data: no]

This regressed between 2006-05-03 and 2006-05-04:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-05-03+06&maxdate=2006-05-04+08&cvsroot=%2Fcvsroot
My guess is a regression from bug 334999.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[tor]

It seems your example depended on a bug with our previous code.  While we're not doing quite the right thing now, we're closer to the spec.

Those errors are correct, as the testcase includes the following code:

function domouseup(e) {
pathdata="";
el.setAttribute("d",pathdata+"z");
window.onmousemove=null;
}

Thus you're trying to set a path of just "z", which according to the BNF in the SVG specification is invalid, as you need at least a moveto to begin a path.

We should be invalidating the path and showing nothing at mouseup with the current testcase.

Comment 3

[tor]

Attachment: invalid path: don't throw error, invalidate

Comment 4

[tor]

Checked in.

Comment 5

[Martijn Wargers (dead)]

Verified fixed, using 2006-06-13 trunk build on windows.