338325 - Fix for 80092 uncovered latent SSL writev non-blocking socket bug

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Chris Newman]

The fix for 80092 uncovered a latent bug in the SSL writev code.  Specifically, when ssl_WriteV gets a partial write on a non-blocking socket (which couldn't happen until 80092 was fixed), it returns an incorrect value for the partial write.  Here's a proposed patch to fix this:

*** sslsock.c   23 Apr 2006 03:05:42 -0000      1.44.2.3
--- sslsock.c   17 May 2006 17:16:42 -0000
***************
*** 1677,1683 ****
        } \
        /* Only a nonblocking socket can have partial sends */ \
        PR_ASSERT(!blocking); \
!       return sent; \
      } 
  #define SEND(bfr, len) \
      do { \
--- 1677,1683 ----
        } \
        /* Only a nonblocking socket can have partial sends */ \
        PR_ASSERT(!blocking); \
!       return sent + rv; \
      } 
  #define SEND(bfr, len) \
      do { \

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Chris, You are SO RIGHT!  Thanks for this bug report!

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Of course, this can only be a problem on a non-blocking socket, 
since ssl_send won't return short writes on blocking sockets.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Attachment: Chris Newman's patch

r=nelson

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

checked in on trunk (for NSS 3.12) and NSS_3_11_BRANCH (For 3.11.2)
Checking in sslsock.c; new revision: 1.44.2.4; previous revision: 1.44.2.3
Checking in sslsock.c; new revision: 1.48; previous revision: 1.47