338326 - [BeOS] Implement HideWindowChrome

Status: RESOLVED FIXED

(Core Graveyard :: Widget: BeOS, defect)

Description

[Sergei Dolgov]

NS_IMETHODIMP nsBaseWidget::HideWindowChrome(PRBool aShouldHide)
to be implemented.

In our case it should switch to B_NO_BORDER_WINDOW_LOOK (or maybe to B_BORDERED_WINDOW_LOOK for safety? very thin borders but user can move it though), and back

Comment 1

[Sergei Dolgov]

Attachment: patch

r?

I tried also B_BORDERED, but it also didn't allow to move window.
So following strictly function description - hiding borders totally

Comment 2

[Sergei Dolgov]

Lottle comment.
If you noticed, I didn't change StandardWindowCreate in nsPopupWindow.cpp.

It means, that even if HideChrome is called for popup (inspite i don't think it will happen) it just changes look to B_NO_BORDER, which is default (and only expected) popup look. So in reality it changes nothing.

Comment 3

[tqh]

Comment on attachment 222398 [details] [diff] [review]
patch

r=[e-mail]

Looks ok to me.

Comment 4

[Sergei Dolgov]

Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.125; previous revision: 1.124
done
Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.56; previous revision: 1.55
done