Closed
Bug 338348
Opened 19 years ago
Closed 18 years ago
Ctrl+9 to select last tab instead of ninth tab, ala IE 7
Categories
(Firefox :: Tabbed Browser, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 2 beta1
People
(Reporter: deanis74, Assigned: zeniko)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
1.07 KB,
patch
|
mconnor
:
review+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
I found this a very nice shortcut in the IE 7 betas. By the time you have enough tabs open to want to select the seventh, eighth, or ninth, you probably can't tell which of those is which. So, really, Ctrl+9 isn't that useful as we have it now. IE 7 has Ctrl+9 as the shortcut to select the last tab, which I currently have to do by hitting Ctrl+Tab a bunch of times.
Assignee | ||
Comment 1•19 years ago
|
||
About like that?
Comment on attachment 222426 [details] [diff] [review]
Ctrl+9 always selects the last tab
Mike, what do you think of this idea?
Attachment #222426 -
Flags: review?(mconnor)
Comment 3•19 years ago
|
||
I'd argue that the shortcut should be Accel-` which is a little closer, finger-wise, to Accel-Tab, and allows someone with nine tabs to hit that ninth one. :)
Nice function to have for Fx2, though, so let's see if we can get it into beta.
Target Milestone: --- → Firefox 2 beta1
Assignee | ||
Comment 4•19 years ago
|
||
Reasons for preferring Ctrl+9:
* The last tab lies usually to the right of the first tab, so should the key for getting there.
* That key you have in mind doesn't exist in that form on my non-en-US keyboard. I'm already far from happy with the FAYT key / (which requires Shift to be pressed), please don't add another one to that list.
Reason against needing Ctrl+9 to access the 9th tab:
* I'm not sure you're able to distinguish tab 9 from tabs 8 and 10 without counting (in which case you're faster using the mouse anyway).
Comment 5•19 years ago
|
||
(In reply to comment #4)
> * That key you have in mind doesn't exist in that form on my non-en-US
> keyboard. I'm already far from happy with the FAYT key / (which requires Shift
> to be pressed), please don't add another one to that list.
Compelling rationale!
> Reason against needing Ctrl+9 to access the 9th tab:
Yeah, I don't think binding it overtop 9 will be a problem, I'm just trying to make sure that the reason for us picking this shortcut actually makes sense. Would you kill me if I asked why not use "0"? ;)
Assignee | ||
Comment 6•19 years ago
|
||
(In reply to comment #5)
> Would you kill me if I asked why not use "0"? ;)
Because it's already used to reset page zoom? Of course we could change that shortcut, since it doesn't make that much sense on non-en-US keyboards, either.
Updated•18 years ago
|
Attachment #222426 -
Flags: review?(mconnor)
Attachment #222426 -
Flags: review+
Attachment #222426 -
Flags: approval-branch-1.8.1+
Updated•18 years ago
|
Assignee: nobody → zeniko
Whiteboard: [checkin needed]
Comment 7•18 years ago
|
||
mozilla/browser/base/content/browser.js 1.637
mozilla/browser/base/content/browser.js 1.479.2.144
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Version: Trunk → 2.0 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•