338611 - xpinstall manager happily tries to install 404 pages

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P2)

Description

[Darin Fisher]

xpinstall manager happily tries to install 404 pages

nsIXPInstallManager::InitManagerFromChrome will try to install URLs that return 404 errors.  It should verify that the HTTP response is a success code before attempting to install the file.

It eventually does fail, but only down deep in the JAR code when the nsZipArchive barfs about the file not being a valid ZIP archive.  I think the problem should be caught in nsXPInstallManager::OnStartRequest.

Comment 1

[Darin Fisher]

Attachment: v1 patch

This does the trick.

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 222704 [details] [diff] [review]
v1 patch

Looks good, r=dveditz. OK for ff2 if you want it.

>         rv = NS_NewLocalFileOutputStream(getter_AddRefs(mItem->mOutStream),
>                                          mItem->mFile,
>                                          PR_WRONLY | PR_CREATE_FILE | PR_TRUNCATE,
>                                          0664);

Would you mind fixing this typo while you're there? The file mode should be 0644

Comment 3

[Darin Fisher]

You meant that it "should _not_ be 0644", right?  0600 is the best choice, I think.

Comment 4

[Darin Fisher]

fixed-on-trunk and fixed1.8.1 w/ switch from 0644 to 0600 in both OnStartRequest and GetDestination (NOT_CHROME case).

Comment 5

[Darin Fisher]

I discussed those permission changes with dveditz over AIM.