Closed Bug 338639 Opened 18 years ago Closed 18 years ago

Autoscroll icon still present on previous page

Categories

(Toolkit :: UI Widgets, defect, P2)

Product:
Toolkit
Component:
UI Widgets
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: ria.klaassen, Assigned: asaf)

References

Details

Attachments

(1 file)

patch
991 bytes, patch
Gavin
: first-review+
Details | Diff | Splinter Review 
Steps to reproduce:
- On a page middle-click to call the scroll icon
- Click on a bookmark
- Click back
Result: the scroll icon is still present (although not functional).
Expected behavior: it should be gone.
Not really a history: session bug. It's really because the autoscroll image is put into the dom of the page.
Depends on: 242621
The regression range pointed to that bfcache bug.
It was between 1.8b2_2005050413 and 1.8b2_2005050415.
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2005-05-04+12%3A00&maxdate=2005-05-04+16%3A00
With bfcache off it regressed once more but later (September 2005).
Attached patch patch — — Splinter Review 
Assignee: nobody → mano
Status: NEW → ASSIGNED

        Attachment #243001 -
        Flags: review?(gavin.sharp)

    
  
Severity: trivial → normal
Component: History: Session → XUL Widgets
Flags: review?(gavin.sharp)
OS: Windows XP → All
Priority: -- → P2
Product: Core → Toolkit
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha1

    
  

        Attachment #243001 -
        Flags: first-review?(gavin.sharp)
QA Contact: history.session → xul.widgets

        Attachment #243001 -
        Flags: first-review?(gavin.sharp) → first-review+

    
    

    
  
mozilla/toolkit/content/widgets/browser.xml 1.95
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  

I am getting the opposite of the original described behavior. It isn't showing the icon, but it is autoscrolling anyhow.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061028 BonEcho/2.0 ID:2006102803

    
    

    
  
Verified FIXED using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061030 Minefield/3.0a1.

Worcester, you're using a version of Firefox that doesn't have this patch in it...
Status: RESOLVED → VERIFIED

    
    

    
  
(In reply to comment #6)
> Verified FIXED using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1)
> Gecko/20061030 Minefield/3.0a1.
> 
> Worcester, you're using a version of Firefox that doesn't have this patch in
> it...
> 
Apologies. I swear I checked and it did not say "Trunk" there before. Again, apologies.

No longer depends on: 242621
Depends on: 517303

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: