338654 - Download completed message reports size as "?" if size was unknown whilst downloading

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Bruce Davidson]

Some server/protocol combinations don't report the size of a file being downloaded. During the download we therefore report this as "?" in the download manager.

Once the file is downloaded we continue to show "?" as the size, but we should report the size of the file we downloaded instead.

The server that normally gives me this problem is a client's Microsoft Outlook Web Access (yuck!) server, and can't currently find publicly available URL illustrating the point.

I have a patch.

Comment 1

[Bruce Davidson]

Attachment: Initial patch

Comment 2

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 222724 [details] [diff] [review]
Initial patch

sr=pink

Comment 3

[Bruce Davidson]

Comment on attachment 222724 [details] [diff] [review]
Initial patch

Sadly not quite that simple. For some reason the download still gets saved with a total size of -1 and therefore when you restart Camino it is detected as "Cancelled".

Comment 4

[Bruce Davidson]

Attachment: Updated patch

Updated patch. File existance is only being checked after we save the download info to the dictionary, which means when you restart Camino the download shows as "Cancelled" because its size is not equal to its current progress.

This patch forces the file existence check first time round, and therefore ensures the right data gets saved to the dictionary.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 222729 [details] [diff] [review]
Updated patch

once again, with more feeling. sr=pink.

Comment 6

[Nick Kreeger]

Comment on attachment 222729 [details] [diff] [review]
Updated patch

Looks good to me.

Comment 7

[Håkan Waara]

Checked in