Closed Bug 338654 Opened 15 years ago Closed 15 years ago

Download completed message reports size as "?" if size was unknown whilst downloading

Categories

(Camino Graveyard :: Downloading, defect)

PowerPC
macOS
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.5

People

(Reporter: mozilla, Assigned: mozilla)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

Some server/protocol combinations don't report the size of a file being downloaded. During the download we therefore report this as "?" in the download manager.

Once the file is downloaded we continue to show "?" as the size, but we should report the size of the file we downloaded instead.

The server that normally gives me this problem is a client's Microsoft Outlook Web Access (yuck!) server, and can't currently find publicly available URL illustrating the point.

I have a patch.
Status: NEW → ASSIGNED
Attached patch Initial patch (obsolete) — Splinter Review
Attachment #222724 - Flags: review?
Comment on attachment 222724 [details] [diff] [review]
Initial patch

sr=pink
Attachment #222724 - Flags: superreview+
Comment on attachment 222724 [details] [diff] [review]
Initial patch

Sadly not quite that simple. For some reason the download still gets saved with a total size of -1 and therefore when you restart Camino it is detected as "Cancelled".
Attachment #222724 - Attachment is obsolete: true
Attachment #222724 - Flags: review?
Attached patch Updated patchSplinter Review
Updated patch. File existance is only being checked after we save the download info to the dictionary, which means when you restart Camino the download shows as "Cancelled" because its size is not equal to its current progress.

This patch forces the file existence check first time round, and therefore ensures the right data gets saved to the dictionary.
Comment on attachment 222729 [details] [diff] [review]
Updated patch

once again, with more feeling. sr=pink.
Attachment #222729 - Flags: superreview+
Comment on attachment 222729 [details] [diff] [review]
Updated patch

Looks good to me.
Attachment #222729 - Flags: review+
Whiteboard: [needs checkin]
Target Milestone: --- → Camino1.1
Checked in
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.