338680 - check isFile before fileSize (loading engines may fail at startup)

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[:Gavin Sharp [email: [e-mail]]]

Apparently at least the Mac GetFileSize throws if the file is a directory, so this causes problems when loading engines.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpcom/io/nsLocalFileOSX.cpp&rev=1.38&mark=731,733,736,739#725

I'm not sure where the NS_ERROR_FILE_NOT_FOUND exception is coming from. Either CFURLGetFSRef is failing in nsLocalFile::GetFSRefInternal, or ::FSGetCatalogInfo is returning fnfErr which gets mapped to NS_ERROR_FILE_NOT_FOUND by MacErrorMapper. I couldn't find any relevant descriptions of the failure conditions for those functions in the Carbon docs, and I'm not familiar with those APIs at all, so I'm guessing that one of those will fail for a directory. The Windows implementation of GetFileSize returns 0 for a directory, and from inspection the Unix version seems to do the same. I guess I should file a bug on at least documenting that in the IDL.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

In case somebody is looking for this here are the exceptions that Dietrich was seeing at startup:

Error: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.fileSize]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: nsSearchService.js :: SRCH_SVC_loadEngines :: line 1697"  data: no]

Error: uncaught exception: [Exception... "ServiceManager::GetService returned failure code:" nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://browser/content/search/search.xml :: get_searchService :: line 112"  data: no]

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.1.2.21

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.26

Comment 6

[Henrik Gemal]

(In reply to comment #2)
> I
> guess I should file a bug on at least documenting that in the IDL.
> 

did you file a bug?