Closed
Bug 338710
Opened 19 years ago
Closed 19 years ago
Some mode responses not shown in output window
Categories
(Other Applications Graveyard :: ChatZilla, defect)
Other Applications Graveyard
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rdmsoft, Assigned: rdmsoft)
References
Details
(Whiteboard: [cz-0.9.75])
Attachments
(1 file)
8.52 KB,
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
When an Unreal server sets channel modes due to flooding, it uses the server name as the source. I've no idea if this is allowed per the spec or not, but we should probably handle it.
+ set (string) 'channel'
+ type (string) 'chanmode'
+ destObject (undefined) undefined
+ destMethod (string) 'onChanMode'
+ hooks (object)
+ data (string) ':sand.mozilla.org MODE #foobar +i'
+ queuedAt (object)
+ level (number) 5
+ currentObject (object)
+ source (string) 'sand.mozilla.org'
+ ignored (boolean) false
+ server (object)
+ params (object)
+ decodeParam (function) 7 lines
+ code (string) 'MODE'
+ channel (object)
+ modeStr (string) '+i'
+ usersAffected (object)
*
Assignee | ||
Updated•19 years ago
|
Assignee: rginda → rdmsoft
Summary: Server-set modes are silently ignored → Some mode responses not shown in output window
Assignee | ||
Comment 1•19 years ago
|
||
Okay, I ended up fixing more than I'd originally planned here, but it's all related. Now, CIRCChannel.onChanMode always shows MODE messages, and will show 324 messages if the channel has the pendingModeReply flag set.
cmdMode accepts any combination of <target> and <modestr>, failing with a more logical error if <target> isn't specified from a network tab.
I also noticed while testing that the 482 (ERR_CHANOPRIVSNEEDED) message was getting dropped, so I added a new string for it.
Attachment #228722 -
Flags: review?(silver)
Comment 2•19 years ago
|
||
Comment on attachment 228722 [details] [diff] [review]
patch
I have to admit to not completely following the diff (thanks to diff sucking), but it looks ok.
> {
> display(getMsg(MSG_ERR_INVALID_MODE, e.modestr), MT_ERROR);
> return;
> }
>-
> var params = (e.param) ? " " + e.paramList.join(" ") : "";
Don't remove that blank line.
r=silver with that fixed.
Attachment #228722 -
Flags: review?(silver) → review+
Comment 3•19 years ago
|
||
Checked in --> FIXED.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
Whiteboard: [cz-0.9.75]
Updated•3 months ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•