338716 - Add a drop-shadow to the seamonkey icon

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Stefan [:stefanh]]

Most app icons has a drop-shadow, I think the seamonkey icon needs one too. This would also be nice to have for the 1.1 release.

I'll attach a zip file with the new icons. Will also attach a the new mac icns file. Unfortunately, I have no tools for providing the windows .ico file.

Comment 1

[Stefan [:stefanh]]

Attachment: Zipped archive with icons (200x200 --> 16x16)

Comment 2

[Stefan [:stefanh]]

Attachment: seamonkey.icns - should go in suite/branding/icons/mac/

The old file is called mozilla.icns - a better name imo would be seamonkey.icns.

Comment 3

[Stefan [:stefanh]]

Attachment: Patch for adding the seamonkey.icns file

Asking review for the mac part (assuming the name change is ok and that the icons are approved, of course).

Comment 4

[Stefan [:stefanh]]

Comment on attachment 222782 [details] [diff] [review]
Patch for adding the seamonkey.icns file

Bumping this to Mnyromyr instead. The request only covers the patch and that the .icns file looks ok. Someone from the Council should probably confirm that the icons in attachment #222778 [details] are ready to go. Note also that I can't make the windows icons.

Comment 5

[Robert Kaiser]

As "someone from the Council" I'd like to note that I think those icons are actually what we want to have esp. on people's desktops :)

Comment 6

[Stefan [:stefanh]]

It would be nice to have this for 1.1a - also on windows. Can someone on windows help? I've seen that there is a Gimp plugin (that doesn't work on mac) that seems to handle this: http://registry.gimp.org/plugin?id=2223

Comment 7

[Stefan [:stefanh]]

Comment on attachment 222782 [details] [diff] [review]
Patch for adding the seamonkey.icns file

Karsten, this patch should work both for suiterunner and xpfe. The .icns file needs to go in two places:

1) xpfe/bootstrap/macbuild/Contents/Resources

2) suite/branding/icons/mac

The old mozilla.icns file could then be  removed.

Comment 8

[Giacomo Magnini]

Attachment: Ico files converted by the gimp (32bit, 8 bit alpha, no palette) for Windows.

Comment 9

[Giacomo Magnini]

Seems like FC5's The Gimp has the ico converter included...
I'm not sure this is the correct format (32bit, 8 bit alpha, no palette), but they do show nicely on Gnome Desktop in preview mode: if not, please provide more details and I'll try to convert them again in the needed format. While I was at it, I've converted all of the images (upto 200x200).
If xpm and/or other formats are needed, please tell me.

Comment 10

[Stefan [:stefanh]]

Giacomo, thanks a lot! Btw, you might get a clue on how the ico file is supposed to be by looking at the old one.

Comment 11

[Robert Kaiser]

Unfortunately, I'm almost convinced this is the wrong format. What we need is one single .ico file that includes the various sizes in various qualities, actually similar to the mac .icns file.
For that, we need to take the current .ico file and only replace the high quality (32-bit RGBA) variants, leaving the lower quality ones unchanged as they were before. This is needed so that Windows can automaticall choose the correct icon depending on the needed size and the screen settings.

Comment 12

[Giacomo Magnini]

Attachment: Modified seamonkey.ico file (only HQ images inserted).

Someone with a win build system will need to check how good the images look on screen, a new .exe is needed for this.

Comment 13

[Stefan [:stefanh]]

Comment on attachment 230420 [details]
Modified seamonkey.ico file (only HQ images inserted).

Hmm, this file looks identical with the existing one (xpfe/bootstrap/mozilla.ico or suite/branding/icons/windows/seamonkey.ico). Is this really the correct file? Note that having a seamonkey.ico file in xpfe/bootstrap will require a patch. Not sure, but I think we use the xpfe one now on branch/trunk - someone else can probably correct me if I'm wrong.

Comment 14

[Stefan [:stefanh]]

Comment on attachment 230420 [details]
Modified seamonkey.ico file (only HQ images inserted).

Hmm, this file looks identical with the existing one (xpfe/bootstrap/mozilla.ico or suite/branding/icons/windows/seamonkey.ico). Is this really the correct file? Note that having a seamonkey.ico file in xpfe/bootstrap will require a patch. Not sure, but I think we use the xpfe one now on branch/trunk - someone else can probably correct me if I'm wrong.

Comment 15

[Stefan [:stefanh]]

Comment on attachment 230420 [details]
Modified seamonkey.ico file (only HQ images inserted).

Hmm, this file looks identical with the existing one (xpfe/bootstrap/mozilla.ico or suite/branding/icons/windows/seamonkey.ico). Is this really the correct file? Note that having a seamonkey.ico file in xpfe/bootstrap will require a patch. Not sure, but I think we use the xpfe one now on branch/trunk - someone else can probably correct me if I'm wrong.

Comment 16

[Stefan [:stefanh]]

Uh, sorry - network issues :-/

Comment 17

[Robert Kaiser]

stefanh: xpfe/bootstrap/mozilla.ico and suite/branding/icons/windows/seamonkey.ico are identical and should both be updated in place with their existing names. the xpfe/ version will be obsoleted when we flip the MOZ_XUL_APP switch anyways.

Comment 18

[Stefan [:stefanh]]

(In reply to comment #17)
> stefanh: xpfe/bootstrap/mozilla.ico and
> suite/branding/icons/windows/seamonkey.ico are identical and should both be
> updated in place with their existing names. the xpfe/ version will be obsoleted
> when we flip the MOZ_XUL_APP switch anyways.
> 

Right, same as mac then.

Comment 19

[Giacomo Magnini]

(In reply to comment #13)
> (From update of attachment 230420 [details] [edit])
> Hmm, this file looks identical with the existing one
> (xpfe/bootstrap/mozilla.ico or suite/branding/icons/windows/seamonkey.ico). Is
> this really the correct file?

It is based on mozilla.ico with only the high res (XP) images replaced with drop shadowed versions. As kairo asked, the rest was left unchanged. My tools here say that they *are* different...

Comment 20

[Giacomo Magnini]

Attachment: SeaMonkey icons at different stages

- seamonkey1.ico has only 48x48 image changed
- seamonkey2 has 48x48 and 32x32
- seamonkey.ico has all of the three XP-kind of images changed to their drop shadowed versions

Rule of thumbs: don't ever trust that a save operation is actually a real save operation in a new tool... ;) Sorry Stefan! :-P

Comment 21

[Stefan [:stefanh]]

Comment on attachment 222782 [details] [diff] [review]
Patch for adding the seamonkey.icns file

We don't need the bootstrap-mac.pkg diff. I guess noone uses that file.

Comment 22

[Robert Kaiser]

(In reply to comment #21)
> (From update of attachment 222782 [details] [diff] [review] [edit])
> We don't need the bootstrap-mac.pkg diff. I guess noone uses that file.

True. Leave the *.pkg files alone, they never have been used. It maybe would be a good idea to remove all of those from the tree (but noone seems to feel like filing a bug and doing so).

Comment 23

[Stefan [:stefanh]]

Attachment: New patch for .icns file without diff of .pkg file

Here's a new patch without the diff of the .pkg file.

Comment 24

[Stefan [:stefanh]]

Comment on attachment 232119 [details] [diff] [review]
New patch for .icns file without diff of .pkg file

This is a visual improvement for mac users. that would be nice to have for 1.1a. I guess the windows part could come later.

Comment 25

[Stefan [:stefanh]]

Attachment: New mozilla.ico, should go in xpfe/bootstrap/

Comment 26

[Stefan [:stefanh]]

Attachment: New seamonkey.ico, should go in suite/branding/icons/windows/

This one and the previous one is identical to Giacomo's seamonkey.ico in the zip file from attachment #230856 [details].

Comment 27

[Stefan [:stefanh]]

Attachment: New icon64.png, should go in suite/branding/content/

This is the 64x64 icon that is used in suiterunner mac alerts.

Comment 28

[Robert Kaiser]

Comment on attachment 232119 [details] [diff] [review]
New patch for .icns file without diff of .pkg file

>Index: xpfe/bootstrap/macbuild/Contents/Info.plist.in
>===================================================================

I'd leave that file alone and continue to name it mozilla.icns in xpfe/ - we're generall using the seamonkey.* names in suite/ only. That also lets us keep cvs history as long as the files of xpfe/ are still used, and makes the patch itself unnecessary on branch (we're only replacing the icons there)...

Comment 29

[Stefan [:stefanh]]

Attachment: New version for .icns file without touching xpfe

New version, transfering r and sr.

Comment 30

[Robert Kaiser]

Comment on attachment 232236 [details] [diff] [review]
New version for .icns file without touching xpfe

Does not apply to branch ;-)

Comment 31

[Stefan [:stefanh]]

Attachment: mozilla.icns for xpfe/bootstrap/macbuild/Contents/Resources/

This is the mozilla.icns for xpfe (identical to seamonkey.icns in attachment #222781 [details]).

Comment 32

[Justin Wood (:Callek)]

this ico file does indeed contain the 3 RGB/A variants with dropshadow added (16x16, 32x32 and 48x48) and continues to hold the same sizes in both 16-bit and 8-bit color.

(Tested with http://www.axdn.com/iconworkshop/ )

Comment 33

[Justin Wood (:Callek)]

Comment on attachment 232226 [details]
New seamonkey.ico, should go in suite/branding/icons/windows/

(erm, last comment applied to this file)

Comment 34

[Justin Wood (:Callek)]

Comment on attachment 232225 [details]
New mozilla.ico, should go in xpfe/bootstrap/

this one checked too.

Comment 35

[Justin Wood (:Callek)]

Hmm, a depend build with the icons replaced did not update them in (windows) seamonkey.exe, [neither in SuiteRunner nor a normal build]; other than clobbering is there anything else I should try?

Comment 36

[Robert Kaiser]

(In reply to comment #35)
> Hmm, a depend build with the icons replaced did not update them in (windows)
> seamonkey.exe, [neither in SuiteRunner nor a normal build]; other than
> clobbering is there anything else I should try?

The windows icon cache is getting into your way. Try switching the desktop icon sizes, IIRC, that should clear that cache.

Comment 37

[Stefan [:stefanh]]

I've got a memo from Justin saying:

"no time to mark it in the bug right now, but the icony drop-shadows _do_ work in clobber win builds."

So, it looks like Giacomo's .ico files are working fine.

Comment 38

[Stefan [:stefanh]]

Comment on attachment 232238 [details]
mozilla.icns for xpfe/bootstrap/macbuild/Contents/Resources/

Neil, this one should go in xpfe. So I assume it needs sr.

Comment 39

[Stefan [:stefanh]]

Comment on attachment 232225 [details]
New mozilla.ico, should go in xpfe/bootstrap/

This one should also go in xpfe...

Comment 40

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 232238 [details]
mozilla.icns for xpfe/bootstrap/macbuild/Contents/Resources/

a=me for 1.1a

Comment 41

[Stefan [:stefanh]]

I think we should probably check this in on trunk first. After a few days bake, we could then drop the icons into branch.

Mnyromyr, could you do the trunk-check-in? It should be pretty straight-forward, all the info is attached to each attachment (Giacomo should have some credits for the .ico files). All non-obsolete attachments except the first one should go in.

Comment 42

[Karsten Düsterloh]

Checked in into trunk:

Checking in app/macbuild/Contents/Info.plist.in;
/cvsroot/mozilla/suite/app/macbuild/Contents/Info.plist.in,v  <--  Info.plist.in
new revision: 1.2; previous revision: 1.1
done
Checking in branding/content/icon64.png;
/cvsroot/mozilla/suite/branding/content/icon64.png,v  <--  icon64.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/suite/branding/icons/mac/seamonkey.icns,v
done
Checking in branding/icons/mac/seamonkey.icns;
/cvsroot/mozilla/suite/branding/icons/mac/seamonkey.icns,v  <--  seamonkey.icns
initial revision: 1.1
done
Checking in branding/icons/windows/seamonkey.ico;
/cvsroot/mozilla/suite/branding/icons/windows/seamonkey.ico,v  <--  seamonkey.ico
new revision: 1.2; previous revision: 1.1
done

Checking in mozilla.ico;
/cvsroot/mozilla/xpfe/bootstrap/mozilla.ico,v  <--  mozilla.ico
new revision: 1.6; previous revision: 1.5
done
Checking in macbuild/Contents/Resources/mozilla.icns;
/cvsroot/mozilla/xpfe/bootstrap/macbuild/Contents/Resources/mozilla.icns,v  <--  mozilla.icns
new revision: 1.5; previous revision: 1.4

Comment 43

[Stefan [:stefanh]]

--> Fixed, thanks Karsten.

Comment 44

[Stefan [:stefanh]]

Comment on attachment 232229 [details]
New icon64.png, should go in suite/branding/content/

Actually, this one is suiterunner-only. So, not needed on branch ;-)

Comment 45

[Karsten Düsterloh]

Checked in into MOZILLA_1_8_BRANCH:

Checking in mozilla.ico;
/cvsroot/mozilla/xpfe/bootstrap/mozilla.ico,v  <--  mozilla.ico
new revision: 1.4.4.2; previous revision: 1.4.4.1
done
Checking in macbuild/Contents/Resources/mozilla.icns;
/cvsroot/mozilla/xpfe/bootstrap/macbuild/Contents/Resources/mozilla.icns,v  <--  mozilla.icns
new revision: 1.2.4.2; previous revision: 1.2.4.1
done