338741 - "Select Element by Click" doesn't work for elements in content documents of inspected chrome

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Inspect a chrome window with a content frame (browser, composer, mail)
2. Try to select an element in content

Expected result: DOM tree is expanded and element is selected.

Actual results: Nothing happens.

Comment 1

[[e-mail]]

Attachment: Proposed patch

It turns out this file already includes nsPIDOMWindow.h so I could have patched it years ago, or if you don't mind I could port the fix to the branch.

Side note: now that DOMI is in layout there looks like scope for more optimization via nsIDocument, nsINode etc.

Comment 2

[[e-mail]]

Fix checked in.

Comment 3

[[e-mail]]

Attachment: Branch port

I can't seem to ask for approval1.8.1 in this product so using r? instead.

Comment 4

[[e-mail]]

Fix checked in to the branch.

Comment 5

[Steffen Wilberg]

(In reply to comment #1)
> It turns out this file already includes nsPIDOMWindow.h
Yeah, bug 316794 added it two week ago. On trunk, that is. It isn't included in the 1.8 branch version...

Comment 6

[Steffen Wilberg]

Attachment: branch bustage fix

I don't know what I'm doing, but this fixes the bustage. Somebody needs to check this in for me on branch.

Comment 7

[Steffen Wilberg]

Comment on attachment 223974 [details] [diff] [review]
branch bustage fix

Checked in on branch.

Comment 8

[[e-mail]]

(In reply to comment #5)
>(In reply to comment #1)
>>It turns out this file already includes nsPIDOMWindow.h
>On trunk, that is. It isn't included in the 1.8 branch version...
D'oh; thanks for fixing my bustage. I wonder why I didn't notice bug 316794. Maybe because bonsai doesn't quite report everything (e.g. your fix appeared on the SeaMonkey 1.8 branch tinderbox but not on the main 1.8 branch tinderbox).

Comment 9

[Steffen Wilberg]

> Maybe because bonsai doesn't quite report everything (e.g. your fix appeared on
> the SeaMonkey 1.8 branch tinderbox but not on the main 1.8 branch tinderbox).
Are you sure? My checkin appeared both on http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8 and on http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8-SeaMonkey at 2006-05-31 14:56.

Comment 10

[[e-mail]]

Weird; I checked both tinderboxes at the time, which is why I mentioned it.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 223974 [details] [diff] [review]
branch bustage fix

Yeah, this is the right thing. Thanks for fixing!