Closed Bug 338803 Opened 18 years ago Closed 18 years ago

Personal Toolbar overflow chevron not properly updated on resize

Categories

(SeaMonkey :: Bookmarks & History, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jag+mozilla, Assigned: jag+mozilla)

References

Details

(Keywords: fixed-seamonkey1.1a, Whiteboard: fixed-seamonkey1.0.3)

Attachments

(2 files)

It checks that the event.target == document when it should be checking that event.target == window (this changed somewhere between 1.7 and 1.9). Patch coming up.
Attachment #222841 - Flags: superreview?(neil)
Attachment #222841 - Flags: review?(cst)
Attachment #222841 - Flags: superreview?(neil) → superreview+
Checking in bookmarksMenu.js;
/cvsroot/mozilla/xpfe/components/bookmarks/resources/bookmarksMenu.js,v  <--  bookmarksMenu.js
new revision: 1.25; previous revision: 1.24
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attached patch for 1.8 branchSplinter Review
Some quick testing doesn't show any breakage, but I couldn't really reproduce the original problem on 1.8.1 anyway.
Attachment #222869 - Flags: superreview?(neil)
Attachment #222869 - Flags: review?(jag)
Attachment #222869 - Flags: review?(jag) → review+
Comment on attachment 222869 [details] [diff] [review]
for 1.8 branch

>-    else if (event.target != document)
>-      return; // only interested in chrome resizes
>+    // XXXcst - work around bug 295340 (broken event targets) on 1.8 branch
>+    //else if (event.target != document)
>+    //  return; // only interested in chrome resizes
Nit: you could have used /* ... */ to avoid changing lines
Attachment #222869 - Flags: superreview?(neil) → superreview+
Are there issues on 1.8.0.x too?  Would the 1.8 patch fix them, if they exist?  If so, we should do this for SM1.0.3.
(In reply to comment #3)
>Some quick testing doesn't show any breakage, but I couldn't really reproduce
>the original problem on 1.8.1 anyway.
I think it depends on how you resize the window.

(In reply to comment #5)
>Are there issues on 1.8.0.x too?  Would the 1.8 patch fix them, if they exist? 
Yes, 1.8.0.x was cut from the 1.8.x branch.
Comment on attachment 222869 [details] [diff] [review]
for 1.8 branch

a=me for SM1.1a
first a=me for SM1.0.3
Attachment #222869 - Flags: approval-seamonkey1.1a? → approval-seamonkey1.1a+
Whiteboard: [cst: land on 1.8.0 after SM1.0.2 ships]
*** Bug 305706 has been marked as a duplicate of this bug. ***
I already verified this as fixed over in bug 305706.
Status: RESOLVED → VERIFIED
Comment on attachment 222869 [details] [diff] [review]
for 1.8 branch

a=me,IanN
Attachment #222869 - Flags: approval-seamonkey1.0.3? → approval-seamonkey1.0.3+
I landed attachment 222869 [details] [diff] [review] on the 1.8.0 branch
Whiteboard: [cst: land on 1.8.0 after SM1.0.2 ships] → fixed-seamonkey1.0.3
You need to log in before you can comment on or make changes to this bug.