338803 - Personal Toolbar overflow chevron not properly updated on resize

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[jag (Peter Annema)]

It checks that the event.target == document when it should be checking that event.target == window (this changed somewhere between 1.7 and 1.9). Patch coming up.

Comment 1

[jag (Peter Annema)]

Attachment: Make the chevron code happy.

Comment 2

[jag (Peter Annema)]

Checking in bookmarksMenu.js;
/cvsroot/mozilla/xpfe/components/bookmarks/resources/bookmarksMenu.js,v  <--  bookmarksMenu.js
new revision: 1.25; previous revision: 1.24
done

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: for 1.8 branch

Some quick testing doesn't show any breakage, but I couldn't really reproduce the original problem on 1.8.1 anyway.

Comment 4

[[e-mail]]

Comment on attachment 222869 [details] [diff] [review]
for 1.8 branch

>-    else if (event.target != document)
>-      return; // only interested in chrome resizes
>+    // XXXcst - work around bug 295340 (broken event targets) on 1.8 branch
>+    //else if (event.target != document)
>+    //  return; // only interested in chrome resizes
Nit: you could have used /* ... */ to avoid changing lines

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Are there issues on 1.8.0.x too?  Would the 1.8 patch fix them, if they exist?  If so, we should do this for SM1.0.3.

Comment 6

[[e-mail]]

(In reply to comment #3)
>Some quick testing doesn't show any breakage, but I couldn't really reproduce
>the original problem on 1.8.1 anyway.
I think it depends on how you resize the window.

(In reply to comment #5)
>Are there issues on 1.8.0.x too?  Would the 1.8 patch fix them, if they exist? 
Yes, 1.8.0.x was cut from the 1.8.x branch.

Comment 7

[Ian Neal]

Comment on attachment 222869 [details] [diff] [review]
for 1.8 branch

a=me for SM1.1a
first a=me for SM1.0.3

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 305706 has been marked as a duplicate of this bug. ***

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

I already verified this as fixed over in bug 305706.

Comment 10

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 222869 [details] [diff] [review]
for 1.8 branch

a=me,IanN

Comment 11

[Andrew Schultz]

I landed attachment 222869 [details] [diff] [review] on the 1.8.0 branch