338823 - Validate instance documents on xforms-rebuild

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect, P2)

Description

[Allan Beaufour]

Right now we only call ValidateDocument() on all instance documents on form load. Should we not be doing it for xforms-rebuild too?

If not, any new inserted nodes will not have the correct type set I guess.

Comment 1

[Allan Beaufour]

(In reply to comment #0)
> Right now we only call ValidateDocument() on all instance documents on form
> load. Should we not be doing it for xforms-rebuild too?
> 
> If not, any new inserted nodes will not have the correct type set I guess.

I'm pretty confident that we should do this.

Comment 2

[aaronr]

It sure sounds logical, but how are we going to represent the invalid document to the user?  If it is failing due to and instance node missing an attribute, for example, and no one links to that attribute, then what do we do?  And even if a control does link to this missing attr then the control won't be there anyhow.  I guess we just log the error?

Comment 3

[Allan Beaufour]

(In reply to comment #2)
> It sure sounds logical, but how are we going to represent the invalid document
> to the user?  If it is failing due to and instance node missing an attribute,
> for example, and no one links to that attribute, then what do we do?  And even
> if a control does link to this missing attr then the control won't be there
> anyhow.  I guess we just log the error?

It's a bit tricky, I agree. Logging the error is also the best I can think of. Problem is that if we do not do it, schema types will not be correct.

Comment 4

[Allan Beaufour]

This needs to be done for bug 339217 to make sense.

Comment 5

[Allan Beaufour]

Attachment: Testcase

Comment 6

[Allan Beaufour]

Attachment: Patch

Comment 7

[Allan Beaufour]

Fixed on trunk.