Closed Bug 338859 Opened 19 years ago Closed 19 years ago

[RFC 2231] even if the attachment file name has 0x2f, it's not escaped

Categories

(MailNews Core :: Attachments, defect)

Product:
MailNews Core
Component:
Attachments
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: masayuki, Assigned: masayuki)

Details

(Keywords: fixed1.8.1, intl, verified1.8.0.5, Whiteboard: QMAIL3 cannot decode the attachment file name by this bug)

Attachments

(1 file)

Patch rv1.0
1.05 KB, patch
mscott
: review+
mscott
: superreview+
mscott
: approval-branch-1.8.1+
dveditz
: approval1.8.0.5+
Details | Diff | Splinter Review
This is conformity bug for RFC 2231. The 0x2f (and maybe 0x2b too) is not escaped on |RFC2231ParmFolding|. I'll attach the patch, soon.
Status: NEW → ASSIGNED
Flags: blocking-thunderbird2?
Attached patch Patch rv1.0 — — Splinter Review
This escapes the 0x2b and 0x2f too.
Attachment #222901 - Flags: superreview?(mscott)
Attachment #222901 - Flags: review?(mscott)
Attachment #222901 - Flags: approval-branch-1.8.1?(mscott)
And, we should not change escaping condition by charset.
Comment on attachment 222901 [details] [diff] [review] Patch rv1.0 looks good to me Masayuki.
Attachment #222901 - Flags: superreview?(mscott)
Attachment #222901 - Flags: superreview+
Attachment #222901 - Flags: review?(mscott)
Attachment #222901 - Flags: review+
Attachment #222901 - Flags: approval-branch-1.8.1?(mscott)
Attachment #222901 - Flags: approval-branch-1.8.1+
checked-in to trunk and 1.8 branch, thanks.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: Should we land on 1.8.0.x?
Flags: blocking-thunderbird2?
Comment on attachment 222901 [details] [diff] [review] Patch rv1.0 We have a report. A MUA that name is QMAIL3 (http://q3.snak.org/download/). That cannot decode our buggy header. But this patch fixes it. We should fix this on 1.8.0 branch too.
Attachment #222901 - Flags: approval1.8.0.5?
Whiteboard: Should we land on 1.8.0.x? → QMAIL3 cannot decode the attachment file name by this bug
Comment on attachment 222901 [details] [diff] [review] Patch rv1.0 approved for 1.8.0 branch, a=dveditz for drivers
Attachment #222901 - Flags: approval1.8.0.5? → approval1.8.0.5+
checked-in to 1.8.0 branch too.
Keywords: fixed1.8.0.5
Masayuki, could you attach an attachment that has this character (?) in its filename so we can verify this bug is fixed? Thanks!
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=3182 Can you test with this .eml file that is encoded iso-2022-jp?
Masayuki, the attachment filename looks the same to me using a build without the patch in it. If you're sure this is fixed, then you can verify it yourself by changing the fixed1.8.0.5 keyword to verified1.8.0.5 and marking the bug as VERIFIED. Thanks!
verified on 1.5.0.x-20060623/Win2k.
Keywords: fixed1.8.0.5 → verified1.8.0.5
-> v. on trunk too.
Status: RESOLVED → VERIFIED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: