338933 - external instance not restored (on xforms-reset) after replace=instance

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

We seem to have problems with restoring external instances (via xforms-reset), when they are external and they have been replaced via submission.
http://groups.google.com/group/mozilla.dev.tech.xforms/browse_frm/thread/abc88b273a0ef9a2/8a0b054c2966476e#8a0b054c2966476e

Comment 1

[Allan Beaufour]

This warning is printed:
WARNING: failed to restore original instance document: 'NS_SUCCEEDED(rv)', file nsXFormsInstanceElement.cpp, line 385

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Hmm, should there be importNode, not cloneNode. At least in trunk.

Comment 3

[Allan Beaufour]

Attachment: Testcase (not working out-of-the-box)

Here's a testcase, but with external instances, etc. it needs to be fiddled with to get working. But it should show "the concept".

Comment 4

[Allan Beaufour]

Attachment: Patch

Just clone the original document and set it as the instance document.

I see no reason for trying to retain the original document element, as we replace that on submissions, etc. anyway.

Comment 5

[Allan Beaufour]

Fixed on trunk