external instance not restored (on xforms-reset) after replace=instance

RESOLVED FIXED

Status

defect
RESOLVED FIXED
13 years ago
3 years ago

People

(Reporter: allan, Assigned: allan)

Tracking

({fixed1.8.0.5, fixed1.8.1})

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(2 attachments)

We seem to have problems with restoring external instances (via xforms-reset), when they are external and they have been replaced via submission.
http://groups.google.com/group/mozilla.dev.tech.xforms/browse_frm/thread/abc88b273a0ef9a2/8a0b054c2966476e#8a0b054c2966476e
This warning is printed:
WARNING: failed to restore original instance document: 'NS_SUCCEEDED(rv)', file nsXFormsInstanceElement.cpp, line 385
Hmm, should there be importNode, not cloneNode. At least in trunk.
Here's a testcase, but with external instances, etc. it needs to be fiddled with to get working. But it should show "the concept".
Posted patch PatchSplinter Review
Just clone the original document and set it as the instance document.

I see no reason for trying to retain the original document element, as we replace that on submissions, etc. anyway.
Assignee: aaronr → allan
Status: NEW → ASSIGNED
Attachment #223029 - Flags: review?(doronr)
Attachment #223029 - Flags: review?(doronr) → review+
Attachment #223029 - Flags: review?(Olli.Pettay)
Attachment #223029 - Flags: review?(Olli.Pettay) → review+
Fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Keywords: fixed1.8.1
Keywords: fixed1.8.0.5
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.