external instance not restored (on xforms-reset) after replace=instance

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
11 years ago
a year ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

({fixed1.8.0.5, fixed1.8.1})

Trunk
fixed1.8.0.5, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
We seem to have problems with restoring external instances (via xforms-reset), when they are external and they have been replaced via submission.
http://groups.google.com/group/mozilla.dev.tech.xforms/browse_frm/thread/abc88b273a0ef9a2/8a0b054c2966476e#8a0b054c2966476e
(Assignee)

Comment 1

11 years ago
This warning is printed:
WARNING: failed to restore original instance document: 'NS_SUCCEEDED(rv)', file nsXFormsInstanceElement.cpp, line 385

Comment 2

11 years ago
Hmm, should there be importNode, not cloneNode. At least in trunk.
(Assignee)

Comment 3

11 years ago
Created attachment 223005 [details]
Testcase (not working out-of-the-box)

Here's a testcase, but with external instances, etc. it needs to be fiddled with to get working. But it should show "the concept".
(Assignee)

Comment 4

11 years ago
Created attachment 223029 [details] [diff] [review]
Patch

Just clone the original document and set it as the instance document.

I see no reason for trying to retain the original document element, as we replace that on submissions, etc. anyway.
Assignee: aaronr → allan
Status: NEW → ASSIGNED
Attachment #223029 - Flags: review?(doronr)

Updated

11 years ago
Attachment #223029 - Flags: review?(doronr) → review+
(Assignee)

Updated

11 years ago
Attachment #223029 - Flags: review?(Olli.Pettay)

Updated

11 years ago
Attachment #223029 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 5

11 years ago
Fixed on trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.5
(Assignee)

Updated

11 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.