Closed
Bug 339023
Opened 19 years ago
Closed 19 years ago
Static strings in widget/windows
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
9.00 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Static strings are bad, because ordering versus nsObsoleteAString::sCanonicalVTable is random in libxul.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #223099 -
Flags: review?(roc)
Comment on attachment 223099 [details] [diff] [review]
Use static PRUnichar* instead, rev. 1
+ if(!newDir.IsEmpty()) {
+ if (mLastUsedUnicodeDirectory) {
+ NS_Free(mLastUsedUnicodeDirectory);
+
+ mLastUsedUnicodeDirectory = ToNewUnicode(newDir);
+ }
+ }
You want to move the assignment out of the innermost if, of course.
r+sr with that.
Attachment #223099 -
Flags: superreview+
Attachment #223099 -
Flags: review?(roc)
Attachment #223099 -
Flags: review+
|
||
Comment 3•19 years ago
|
||
Im working on IStream implementation for file drags now (bug # 2267426), so when I finish it statics will be gone.
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed on trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•