Status

Core Graveyard
XForms
--
trivial
RESOLVED FIXED
11 years ago
10 months ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

({fixed1.8.0.5, fixed1.8.1})

Trunk
fixed1.8.0.5, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Warning: test for equality (==) mistyped as assignment (=)?
Source File: chrome://xforms/content/input-xhtml.xml
Line: 345, Column: 48
Source Code:
                while (child = walker.nextNode()) {

Warning: function getDaysCount does not always return a value
Source File: chrome://xforms/content/widgets.xml
Line: 244, Column: 7
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

11 years ago
Created attachment 223168 [details] [diff] [review]
Patch

I'm a bit unsure about the "return 0". We could throw an error or something? But we have no generic mechanism in place for that now, do we?
Attachment #223168 - Flags: review?(Olli.Pettay)

Comment 2

11 years ago
Comment on attachment 223168 [details] [diff] [review]
Patch

IMO, it is ok to return 0.
Attachment #223168 - Flags: review?(Olli.Pettay) → review+

Comment 3

11 years ago
(In reply to comment #0)
> Warning: test for equality (==) mistyped as assignment (=)?
> Source File: chrome://xforms/content/input-xhtml.xml
> Line: 345, Column: 48
> Source Code:
>                 while (child = walker.nextNode()) {
> 

It's not bug. Probably we should do some changes in syntacsis to avoid that warning.

> Warning: function getDaysCount does not always return a value
> Source File: chrome://xforms/content/widgets.xml
> Line: 244, Column: 7
> 

As you said we can return 0. In any case it's not matter because the value of calendar is setted by using 'value' property and that property can't lead to error month values I guess.
(Assignee)

Comment 4

11 years ago
(In reply to comment #3)
> (In reply to comment #0)
> > Warning: test for equality (==) mistyped as assignment (=)?
> > Source File: chrome://xforms/content/input-xhtml.xml
> > Line: 345, Column: 48
> > Source Code:
> >                 while (child = walker.nextNode()) {
> > 
> 
> It's not bug. Probably we should do some changes in syntacsis to avoid that
> warning.

That is what the patch does ;-)

Comment 5

11 years ago
Comment on attachment 223168 [details] [diff] [review]
Patch


>           }
>+          // XXX: throw error?
>+          return 0;

I guess we don't need in XXX comment. We report about error by returning zero value.

Comment 6

11 years ago
(In reply to comment #4)

> 
> That is what the patch does ;-)
> 

Yes :)), I didn't look at it. I like the patch excepting XXX comment.
(Assignee)

Comment 7

11 years ago
(In reply to comment #6)
> (In reply to comment #4)
> 
> > 
> > That is what the patch does ;-)
> > 
> 
> Yes :)), I didn't look at it. I like the patch excepting XXX comment.

:) Fixed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.5
(Assignee)

Updated

11 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.