339092 - Extensions aren't removed from profile

Status: RESOLVED DUPLICATE of bug 258301

(Toolkit :: Add-ons Manager, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3
Build Identifier: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060308 Thunderbird/1.5.0.2 Mnenhy/0.7.4.666

Not sure whether this is a bug in thunderbird or in the extension, but here goes:

I have installed and removed thunderbird extension Mnenhy, but the extension is still listed in my profile folder APPDATA%\Thunderbird\*.default\extensions.rdf.

Also the preferences special to this extension aren't removed from prefs.js.

And this extension is also still listed in my User-agent, which is sent in every e-mail (and is displayed here in my build identifier...).


Reproducible: Always

Steps to Reproduce:
1. Install extension Mnenhy
2. Uninstall extension Mnenhy
3. Check files prefs.js, extensions.rdf, mnenhy* in your profile directory

Comment 1

[Wayne Mery (:wsmwk)]

strikes me as being partly dupe, and perhaps partly the extension. shouldn't Mnenhy remove the pref/User-agent?

Comment 2

[Dave Townsend [:mossop]]

What do you see in extensions.rdf that you think is still related to Mnenhy?

Comment 3

[Onno Ekker [:nONoNonO UTC+1]]

It's now long gone in my extensions.rdf. Maybe (probably) I only stopped Thunderbird and the information doesn't get removed from extensions.rdf until Thunderbird is started again?

And Mnenhy should at least remove the user-agent. It shouldn't even modify the user-agent in the first place, I think. That was the main reason I uninstalled it. I just reinstalled it last week in a separate profile, to check on a question asked on support-thunderbird, b

I'm not too sure about the preferences, though. Maybe it is safe to remove user set preferences from prefs.js, when an extension is uninstalled? You could remove all the preferences that have their defaults specified in defaults/prefences/*.js? I don't think the extension can do that itself, when it is uninstalled.

Comment 4

[Onno Ekker [:nONoNonO UTC+1]]

Hmz... I was in the mid of a sentence: support question was about registry.dat file in profile directory, and I installed Mnenhy again because I read it has a registry viewer.

I already had Mnenhy profile removed again, but now to answer your questions I made a new profile again, installed mnenhy again, changed some settings and uninstalled mnenhy.

When using Thunderbird's own option Tools->Add-ons->Mnenhy->Uninstall, the user-agent isn't even reset:
user_pref("general.useragent.override", "Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.8.1.16) Gecko/20080708 Thunderbird/2.0.0.16 Mnenhy/0.7.5.666");

I noticed now that Mnenhy also has its own uninstaller, available under Tools->Add-ons->Mnenhy->Options->Mnenhy uninstaller. This shows me a popup that it will uninstal Mnenhy, but not the Mnenhy customizations file. So its not that strange I still see mnenhy.rdf and mnenhy-folderstore.rdf in my profile folder after uninstalling Mnenhy. Uninstalling Mnenhy this way, does restore the user-agent to it's default value.

So what's left of my bug report are the settings. See also comment #3. Maybe apart from the settings that are specified in defaults/preferences, it could also be safe to remove prefs starting with "extensions.<add-on-name>".

Wayne is probably right about this being a dupe, I'll see if I can find something later. And it can be a choice to leave the settings too. So that people that want to reinstall an extension later on, don't have to start all over again with configuring it.

The other thing that is related, is that it should maybe be possible for extensions to hook up in an easy way to the uninstall procedure, to perform extra cleanup functions. I'll see if I can find an existing RFE about that too.

Comment 5

[Dave Townsend [:mossop]]

This seems to be a dupe of about 3 different issues, but this will do.