Closed Bug 339098 Opened 18 years ago Closed 18 years ago

NSIS Installer: Space required: 0.0kb for custom install and components

Categories

(Firefox :: Installer, defect)

Product:
Firefox
Component:
Installer
Version:
2.0 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 2 beta1

People

(Reporter: u88484, Assigned: robert.strong.bugs)

References

(
URL
)

Details

(Keywords: verified1.8.1)

Attachments

(3 files)

Screenshot
17.22 KB, image/png
Details
Screen shot of another window
15.48 KB, image/png
Details
patch
2.49 KB, patch
moco
: review+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review 
Using the new NSIS installer, during installation when you do a custom install and select which components to install (QFA or Developer Tools) the installer does not show how much space is required...just shows 'Space required: 0.0KB'
Flags: blocking-firefox2?
Summary: NSIS Installer does not shown space required for custom install → NSIS Installer does not show space required for custom install
Attached image Screenshot — 

    
  
Summary: NSIS Installer does not show space required for custom install → NSIS Installer: Space required: 0.0kb for custom install and components

    
    

    
  


  

    
  
Blocks: 339061

    
    

    
  
According to http://forums.mozillazine.org/viewtopic.php?p=2281310 this is probably not a bug.
Assignee: nobody → robert.bugzilla
Whiteboard: 1d
Target Milestone: --- → Firefox 2 beta1

    
    

    
  
That post has a zany theory :)  This is a bug.
Flags: blocking-firefox2? → blocking-firefox2+

    
    

    
  
I have a patch and will submit as soon as bug 340173 lands.
Whiteboard: 1d

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #226569 -
        Flags: review?(sspitzer)

    
    

    
  
Comment on attachment 226569 [details] [diff] [review]
patch

the specifics of the stack syntax are still new to me, but at least I actually understood this one!

r=sspitzer

        Attachment #226569 -
        Flags: review?(sspitzer) → review+

    
    

    
  
Fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

        Attachment #226569 -
        Flags: approval1.8.1?

        Attachment #226569 -
        Flags: approval1.8.1?

    
    

    
  
Comment on attachment 226569 [details] [diff] [review]
patch

Needed to display the size of the application as well as adding of the size of optional components during install.

        Attachment #226569 -
        Flags: approval1.8.1?

    
  

        Attachment #226569 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
Checked in to MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1

    
  
Status: RESOLVED → VERIFIED
Keywords: verified1.8.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: