339177 - Locked preferences not locked for Limited Users

Status: RESOLVED FIXED

(Other Applications :: CCK, defect)

Description

[Robert Parenton]

When using a globally installed .xpi created using CCK 1.0.1 on Firefox 1.5.0.3, none of the preferences that are supposed to be locked are locked when Firefox is run by a limited user on Windows XP.  The preferences are locked properly when Firefox is run by a user with admin permissions.

Comment 1

[Robert Parenton]

Attachment: cck.config the problem is experienced with

Comment 2

[Mike Kaply [:mkaply]]

That's very strange. Do other things in the CCK apply?

Comment 3

[Robert Parenton]

Yes, the preferences are actually applied, and used and the certificate is properly added as a trusted CA.  The bundled extensions are also installed properly when it is installed globally.  The preferences simply aren't locked when the Options panel is opened by a limited user.  This also affects new profiles as well.

I can send you the .xpi if that would help (I would rather not attach it since it includes the CA certificate (but not the key)).

Comment 4

[Mike Kaply [:mkaply]]

I must confess I'm at a complete loss as to what could possibly be causing this.

I lock the preferences here:

http://lxr.mozilla.org/seamonkey/source/extensions/cck/browser/resources/content/cckwizard/srcfiles/cckService.js.in#248

and the actual code is here:

http://lxr.mozilla.org/seamonkey/source/modules/libpref/src/prefapi.cpp#606

There shouldn't be anything windows specific that keeps this from happening...

How exactly do I create a limited user? Is just creating a non admin user enough?

Comment 5

[Robert Parenton]

Yes, by limited user I meant a normal user without Administrator or Power User privileges.  In the Users applet in the Control Panel, there is an option to create a "Limited" user when you go to create a user.

Comment 6

[Robert Parenton]

The only thing that a limited user would not have permission to do that is specified in the cck.config is write to the registry keys under HKEY_LOCAL_MACHINE.  Not sure if that helps or not.

Comment 7

[Mike Kaply [:mkaply]]

Interesting. I bet what is happening here is that my key.create is throwing an exception that is not being caught, so none of the following Javascript is being executed.

I'll put a patch together tomorrow for you to try.

Comment 8

[Mike Kaply [:mkaply]]

Attachment: Fix for problem

add a try catch block around the relevant registry calls just in case they fail.

Comment 9

[Mike Kaply [:mkaply]]

fix checked in. It will be in the official 1.0.2 which will be out soon.