Closed Bug 339321 Opened 14 years ago Closed 14 years ago

Sunbird credits dialog uses no fade in / fade out graphics [Windows]

Categories

(Calendar :: Sunbird Only, defect, minor)

x86
Windows 2000
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: mattwillis)

Details

Attachments

(2 files)

On Windows system the Sunbird credits dialog uses no fade in / fade out graphics. On Linux system fade in / fade out graphics are used.

Expected Results:
Eye candy for Windows users.
This does not look like an error in xul or js code but rather with the png images used. It seems that the image files got corrupted during build or packaging.

In Sunbird the following two icons are included:

  mozilla/calendar/sunbird/base/content/aboutCredits.png
  mozilla/calendar/sunbird/base/content/aboutFooter.png

If I open this image files from my local cvs tree everything is ok. 
But if I open the image files that are included in calendar.jar in the nightly tinderbox build I get an error message like: "Decoding error. Wrong or unknown PNG file."

According to the png standard the file starts with:
0x89 0x50 0x4E 0x47 0x0D 0x0A - that is ASCII letters "PNG" followed by a windows style line ending (CRLF). [http://en.wikipedia.org/wiki/PNG]

This is the case when looking at the files in cvs tree with a hex editor.

But in the image files included in calendar.jar the windows style line ending (CRLF) was replaced by a unix style line ending (LF). This renders the png file unusable. If I replace LF with CRLF line ending the images are displayed fine in about dialog.
Assignee: nobody → mattwillis
Status: NEW → ASSIGNED
Attachment #226585 - Flags: first-review?(jminta)
Comment on attachment 226585 [details] [diff] [review]
rev0 - disable preprocessing for pngs

r=jminta
Attachment #226585 - Flags: first-review?(jminta) → first-review+
patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Verified in nightly:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060622 Sunbird/0.3a2+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.