339327 - [FIX]Plugins (RealPlayer, Flash, Quicktime) broken on trunk (no plugin content displayed)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
0. Fetch trunk build
1. Go to http://webportal.bundestag.t-bn.de/Fernsehtext/html/index300.html
2. Notice you get some sound but no picture at all and the RealPlayer GUI is also not displayed; the RealPlayer plugin should be visible on the left side

Sometimes if you right click where the plugin should be it crashes.

This regressed between 20060521-09 and 20060522-08. Possibly fall-out from Bug 236873, the fix in Bug 338834 did not fix this bug here (build from 20060523-10 is still broken).

Comment 1

[Frank Wein [:mcsmurf]]

Locally backing out Bug 236873 fixed the issue.

Comment 2

[Peter Van der Beken [:peterv]]

A smaller testcase would help.

Comment 3

[Frank Wein [:mcsmurf]]

Check the URL for a somewhat minimal testcase. Do you see the bug there? stephend reported me this is wfm in his trunk build, so i'm not sure if you see this, too.

Comment 4

[Peter Van der Beken [:peterv]]

Hmm, after downloading the latest RealPlayer for OS X I do have an image (currently a static picture: 'Programmvorschau') and sound. I don't see the Java applet on the right side, trying to figure out why.

Comment 5

[Frank Wein [:mcsmurf]]

I asked a bit around on IRC, another person was seeing the bug, too. Yet another person did not see the bug. Both were using Windows, so it seems this bug might not be seen on all systems, but it's a good idea to test on Windows if you have it available.

Comment 6

[Uri Bernstein]

I'm seeing a similar problem with Flash content, with a similar regression range (20060521-06 to 20060522-04).
I'm seeing this on Mac, but it was originally reported to me (by Nir Ichie) on Windows.

A sample page where this happens is http://www.discus-israel.com/DIndex/shrimpdex/profiles/japonica.htm , where a small Flash movie should appear on the last line of the table. I can upload a minimal testcase based on that page if necessary.

I assume this is the same bug (although this one talks about RealPlayer), but if required, I'll file a separate one.

Comment 7

[Frank Wein [:mcsmurf]]

And if you look for a example with the Quicktime plugin, check http://homepage.mac.com/tracer302/MacBookPro/iMovieTheater80.html. I did not check  if it matches the regression range but i'm quite sure it's the same as this bug here (since QT always worked in the past).

Comment 8

[Uri Bernstein]

(In reply to comment #7)
> And if you look for a example with the Quicktime plugin, check
> http://homepage.mac.com/tracer302/MacBookPro/iMovieTheater80.html. I did not
> check  if it matches the regression range but i'm quite sure it's the same as
> this bug here (since QT always worked in the past).
> 

Yes, I verified that the regression for that page is the same as for the other issues.

I'm editing the summary to reflect the fact that this affects all kinds of plugins, not just RealPlayer.
Also setting Hardware/OS to All/All.

Comment 9

[Boris Zbarsky [:bzbarsky]]

This would really benefit from a minimal testcase attached to the bug...

Comment 10

[Uri Bernstein]

Attachment: Flash for testcase

Comment 11

[Uri Bernstein]

Attachment: testcase (for Flash)

You should see a small Flash animation at the top left corner of the page.
With recent trunk builds I just see a blank page.

Comment 12

[Uri Bernstein]

Or, try this for a truly minimal testcase:

data:text/html,<embed src="https://bugzilla.mozilla.org/attachment.cgi?id=224369">

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Uri, thanks for the testcase!

The basic issue was that for <embed> IsDoneAddingChildren() always returned false, so we bailed early out of nsObjectFrame::Reflow and never set up the right sizing on the plugin window.

Comment 14

[Peter Van der Beken [:peterv]]

Comment on attachment 224458 [details] [diff] [review]
Fix

Thanks.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Fixed.