339356 - javascript: bookmarks on personal toolbar activated when viewing properties

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[ignazvonstraubing+bugzilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a1) Gecko/20060525 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a1) Gecko/20060525 Minefield/3.0a1

javascript: bookmarks on the Personal Toolbar are activated when Properties is selected from their context menu. After the JavaScript has finished doing its thing, the properties window pops up.

This bug has been around for some time now.

Reproducible: Always

Steps to Reproduce:
1. Add the following bookmark to the personal toolbar: javascript:alert('hello')
2. Right-click bookmark and select Properties

Actual Results:  
JavaScript is executed before Properties window is shown

Expected Results:  
JavaScript should not execute

Comment 1

[Mike Connor [:mconnor]]

oops, wrong bug!

Comment 2

[Peter van der Woude [:Peter6]]

related to 339378 ?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> related to 339378 ?

yes.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Now that bug 339377 has been fixed, is this still happening?

Comment 5

[ignazvonstraubing+bugzilla]

I'm not seeing it anymore; using the 20060531 build.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Yeah, fixed by bug 339377.

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv