339381 - Make Bugzilla::Classification use Bugzilla::Object

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

Comment 1

[Frédéric Buclin]

We are in "soft freeze" mode to prepare 3.0 RC1.

Comment 2

[Frédéric Buclin]

When fixing this one, please also fix Classification::get_all_classifications(), which is suboptimal, and make it use ->new_from_list().

We could probably take it for 3.0 if someone wants to fix it.

Comment 3

[Max Kanat-Alexander]

Bugzilla 3.2 is now frozen. Only enhancements blocking 3.2 or specifically approved for 3.2 may be checked in to the 3.2 branch. If you would like to nominate your enhancement for Bugzilla 3.2, set the "blocking3.2" flag to "?", and either the target milestone will be changed back, or the blocking3.2 flag will be granted, if we will accept this enhancement for Bugzilla 3.2.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1

Note that editclassifications.cgi doesn't use Bugzilla::Object methods yet. This will done in bug 313126. Also, validators are based on the exact current behavior.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 354518 [details] [diff] [review]
patch, v1

This is fine, though we have a policy of not checking in code until it's used, so we should wait until the set_ functions and validators are actually being used before we check them in.

Comment 6

[Frédéric Buclin]

Attachment: patch, v1.1

There was a missing |return $name;| in _check_name() in my previous patch. No other change.

Comment 7

[Frédéric Buclin]

Attachment: patch, v1.2

running runtests.pl -v 12 shows that the "classification_doesnt_exist" error tag is no longer in use. Removing it. Carrying forward r+.

Comment 8

[Frédéric Buclin]

Bug 313126 is ready for checkin, so I can now commit both.

Comment 9

[Frédéric Buclin]

Checking in editclassifications.cgi;
/cvsroot/mozilla/webtools/bugzilla/editclassifications.cgi,v  <--  editclassifications.cgi
new revision: 1.32; previous revision: 1.31
done
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.147; previous revision: 1.146
done
Checking in Bugzilla/Classification.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Classification.pm,v  <--  Classification.pm
new revision: 1.12; previous revision: 1.11
done
Checking in Bugzilla/Product.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Product.pm,v  <--  Product.pm
new revision: 1.33; previous revision: 1.32
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <-- user-error.html.tmpl
new revision: 1.268; previous revision: 1.267
done