Closed Bug 339399 Opened 18 years ago Closed 18 years ago

In <mailCommands.js>, "Warning: assignment to undeclared variable id"

Categories

(MailNews Core :: Composition, defect)

Product:
MailNews Core
Component:
Composition
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.8.1beta1

People

(Reporter: sgautherie, Assigned: sgautherie)

Details

(Keywords: fixed-seamonkey1.1a, verified1.8.1, Whiteboard: [verified-seamonkey1.1a])

Attachments

(5 obsolete files) 

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a2) Gecko/20060524 SeaMonkey/1.1a] (nightly) (W98SE)

{{
Warning: assignment to undeclared variable id
Source File: chrome://messenger/content/mailCommands.js
Line: 106
}}

From a LXR search, the involved code is the same for Trunk/branch and SM/TB.
*Adds the missing |var id|.
*Does some rewrites.
*Fixes lots of space nits.
*Does some synchronization with the Thunderbird file.
Assignee: nobody → gautheri
Status: NEW → ASSIGNED
Attachment #223845 - Flags: review?(iann_bugzilla)
Comment on attachment 223845 [details] [diff] [review]
(Av1-SM-Bw) <mailCommands.js> (for review only)

Looks okay, though please make sure you use a context of 8 for future diffs.
Attachment #223845 - Flags: review?(iann_bugzilla) → review+
Av1-SM-Bw, with full diff.

(Is superreview needed for this ?)
Attachment #224564 - Flags: review?(iann_bugzilla)
Comment on attachment 224564 [details] [diff] [review]
(Av1-SM) <mailCommands.js>
[Checkin: Comment 7]

Make sure you get an sr= too
Attachment #224564 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 224564 [details] [diff] [review]
(Av1-SM) <mailCommands.js>
[Checkin: Comment 7]

'approval-branch-1.8.1=?': (SeaMonkey only)
Trivial U.I. code cleanup, no risk.
Attachment #224564 - Flags: superreview?(mnyromyr)
Attachment #224564 - Flags: approval-branch-1.8.1?(mnyromyr)
Comment on attachment 224564 [details] [diff] [review]
(Av1-SM) <mailCommands.js>
[Checkin: Comment 7]

Sorry, I'm neither Super-Reviewer nor member of the SeaMonkey Council
Attachment #224564 - Flags: superreview?(neil)
Attachment #224564 - Flags: superreview?(mnyromyr)
Attachment #224564 - Flags: approval-branch-1.8.1?(neil)
Attachment #224564 - Flags: approval-branch-1.8.1?(mnyromyr)
Attachment #224564 - Flags: superreview?(neil)
Attachment #224564 - Flags: superreview+
Attachment #224564 - Flags: approval-branch-1.8.1?(neil)
Attachment #224564 - Flags: approval-branch-1.8.1+
Attachment #223845 - Attachment is obsolete: true
Comment on attachment 224564 [details] [diff] [review]
(Av1-SM) <mailCommands.js>
[Checkin: Comment 7]


Checkin: {
2006-06-16 21:07	bugzilla%standard8.demon.co.uk 	mozilla/mailnews/base/resources/content/mailCommands.js 	1.102
}
Attachment #224564 - Attachment description: (Av1-SM) <mailCommands.js> → (Av1-SM) <mailCommands.js> [Checkin: Comment 7]
Av1-SM patch, ported to Thunderbird:
see comment 1.
Attachment #226028 - Flags: review?(bryner)
Comment on attachment 226028 [details] [diff] [review]
(Bv1-TB) <mailCommands.js>
[Checkin: Comment 13]

Please find a Thunderbird peer to review this.
Attachment #226028 - Flags: review?(bryner)
Attachment #226028 - Flags: review?(mscott)
Av1-SM, synchronized to MOZILLA_1_8_BRANCH,
which lacks bug 45715 fix.

Keeping
{
(Av1-SM) <mailCommands.js> [Checkin: Comment 7]   	 patch   	2006-06-06 08:36 PDT  	32.78 KB  	neil: approval&#8209;branch&#8209;1.8.1+
}
Attachment #226103 - Flags: approval-branch-1.8.1+
Attachment #224564 - Attachment is obsolete: true
Comment on attachment 226103 [details] [diff] [review]
(Cv1-SM-181) <mailCommands.js>
[Checkin: Comment 11]


Checkin: {
2006-06-19 08:13	neil%parkwaycc.co.uk 	mozilla/mailnews/base/resources/content/mailCommands.js 	1.96.4.3 	MOZILLA_1_8_BRANCH
}
Attachment #226103 - Attachment description: (Cv1-SM-181) <mailCommands.js> → (Cv1-SM-181) <mailCommands.js> [Checkin: Comment 11]
Attachment #226103 - Attachment is obsolete: true
Attachment #226028 - Flags: review?(mscott) → review+
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060620 SeaMonkey/1.1a] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH.
Whiteboard: [verified-seamonkey1.1a]
patch Bv1-TB checked into trunk.
Bv1-TB, synchronized to MOZILLA_1_8_BRANCH.

'approval1.8.1=?': (ThunderBird only)
Trivial U.I. code cleanup, no risk.
Attachment #227671 - Flags: approval1.8.1?
Attachment #226028 - Attachment description: (Bv1-TB) <mailCommands.js> → (Bv1-TB) <mailCommands.js> [Checkin: Comment 13]
Attachment #226028 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8.1beta1
MScott can you weigh in on 1.8 branch approval for us?
Attachment #227671 - Flags: approval1.8.1? → approval1.8.1+
fixed on 2.0 branch build
Keywords: fixed1.8.1
Attachment #227671 - Attachment description: (Dv1-TB-181) <mailCommands.js> → (Dv1-TB-181) <mailCommands.js> Checkin: Comment 16]
Attachment #227671 - Attachment is obsolete: true
[Mozilla Thunderbird, version 2 alpha 1 (20060713)] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
PS: Well, actually, I did not verify the resolution on Trunk...
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: