339528 - move to dist/bin/extensions broke unit tests

Status: RESOLVED INCOMPLETE

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Description

[Brian Ryner (not reading)]

xpcshell no longer finds the metrics components during component registration, so the tests fail.

I've been experimenting with dynamically registering the extensions/[e-mail]/components directory.  It registers the component ok, but does not register the typelibs in that directory, which causes the unit test script to fail.  We could register a directory provider for XPCOM_COMPONENT_DIR_LIST, but that will be too late -- the InterfaceInfoManager only consults this before XPCOM startup.

Darin, any suggestions here?  Perhaps we could make xpcshell be a DirectoryServiceProvider for the component dir list, and have it get that path from a command line flag?

Comment 1

[Brian Ryner (not reading)]

Attachment: allow a component directory list to be supplied via an envrionment variable

You might wonder, "why an environment variable and not a command-line flag"?  Unfortuantely, the way xpcshell is set up right now, it wants to process command line flags after it has started up XPCOM and Spidermonkey.  We need this earlier, so...

Comment 2

[Brian Ryner (not reading)]

Actually, I'm starting to think we should do it as a command line flag and just do a pass over argv before initializing XPCOM.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 224336 [details] [diff] [review]
allow a component directory list to be supplied via an envrionment variable

This looks fine, but I think I'd also prefer either an earlier or a second pass over the command-line arguments.