339565 - google.com textfield autocomplete shows unexpectedly with gok

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Ginn Chen]

1) open www.google.com, make sure firefox saved some values for the text field.
2) focus the text field (it is focused by default when www.google.com is loaded)
autocomplete dropdown isn't shown at this time
3) "ui grab" with gok, click "About Google" button in gok window
4) "About Google" page rendered with textfield autocomplete dropdown at the middle of the page

I'm not sure if this bug belongs to A11y, but I can only reproduce it with gok.

Comment 1

[Ginn Chen]

Attachment: Screenshot

btw: if focus is not in the textfield as step 2), this bug can't be reproduce.

Comment 2

[Nian Liu(n/a in a long time)]

at-poke shows first autocomplete get the focus then link "about google" get the focus.

Comment 3

[Nian Liu(n/a in a long time)]

Attachment: patch

mimic real ui event.

Comment 4

[Aaron Leventhal]

Comment on attachment 224400 [details] [diff] [review]
patch

Cool.

Comment 5

[[e-mail]]

Comment on attachment 224400 [details] [diff] [review]
patch

>     nsIPresShell *presShell = doc->GetShellAt(0);
...
>-      content->HandleDOMEvent(presShell->GetPresContext(), &clickEvent, nsnull,
>-                              NS_EVENT_FLAG_INIT, &eventStatus);
>+      presShell->HandleDOMEventWithTarget(content, &downEvent, &eventStatus);
>+      presShell->HandleDOMEventWithTarget(content, &upEvent, &eventStatus);
>+      presShell->HandleDOMEventWithTarget(content, &clickEvent, &eventStatus);
These calls can theoretically destroy the pres shell. Before, there was only one call, so it didn't matter. However, you now need to store the pres shell in an nsCOMPtr to ensure that it continues to exist. sr=me with that fixed.

Comment 6

[Nian Liu(n/a in a long time)]

> These calls can theoretically destroy the pres shell. Before, there was only
Neil,

can you help me know how that destroy the pres shell?
> one call, so it didn't matter. However, you now need to store the pres shell in
> an nsCOMPtr to ensure that it continues to exist. sr=me with that fixed.
> 

Comment 7

[Nian Liu(n/a in a long time)]

aaron,

we need to change nsIPresShell *presShell = doc->GetShellAt(0);
           to     nsCOMPtr<nsIPresShell> presShell = doc->GetShellAt(0);

as Neil addressed.

Comment 8

[[e-mail]]

(In reply to comment #6)
>can you help me know how that destroy the pres shell?
Basically, any event can invoke JavaScript which can close the window.

Comment 9

[Aaron Leventhal]

Okay, made the nsCOMPtr<> change.

Comment 10

[Mike Schroepfer]

We'll plus the patch when beta 1 clears...

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 224400 [details] [diff] [review]
patch

You are cleared to land, sir.

Comment 12

[Ginn Chen]

Checking in src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.165.2.8; previous revision: 1.165.2.7
done