Implement a stub imgIDecoderObserver in content/layout to save code size

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
Layout: Misc Code
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
In bug 321054 comment 47 darin suggested implementing a stub imgIDecoderObserver implementation with all the methods empty so that the empty methods could be shared between the many implementations in content/layout.  This would be a lot like the existing nsStubDocumentObserver class.
(Assignee)

Comment 1

12 years ago
Created attachment 225680 [details] [diff] [review]
patch

I couldn't touch nsImageLoadingContent and nsObjectLoadingContent because they inherit from interfaces that inherit from imgIDecoderObserver rather than inheriting directly.
(Assignee)

Updated

12 years ago
Attachment #225680 - Flags: superreview?(bugmail)
Attachment #225680 - Flags: review?(bugmail)
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Whiteboard: [patch]
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 225680 [details] [diff] [review]
patch

looks great, r+sr=sicking
Attachment #225680 - Flags: superreview?(bugmail)
Attachment #225680 - Flags: superreview+
Attachment #225680 - Flags: review?(bugmail)
Attachment #225680 - Flags: review+
(Assignee)

Comment 3

12 years ago
Checked in to trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 4

12 years ago
This appears to have brought btek Tp down by about 2 ms. Yay! A bit hard to say for sure since it was followed by the patch for bug 339041 which brought it down an additional 4 or 5 ms.
Depends on: 504617
You need to log in before you can comment on or make changes to this bug.