339612 - Implement a stub imgIDecoderObserver in content/layout to save code size

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In bug 321054 comment 47 darin suggested implementing a stub imgIDecoderObserver implementation with all the methods empty so that the empty methods could be shared between the many implementations in content/layout.  This would be a lot like the existing nsStubDocumentObserver class.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I couldn't touch nsImageLoadingContent and nsObjectLoadingContent because they inherit from interfaces that inherit from imgIDecoderObserver rather than inheriting directly.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 225680 [details] [diff] [review]
patch

looks great, r+sr=sicking

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.

Comment 4

[jag (Peter Annema)]

This appears to have brought btek Tp down by about 2 ms. Yay! A bit hard to say for sure since it was followed by the patch for bug 339041 which brought it down an additional 4 or 5 ms.