339710 - Can't use "Go" button" with using keyword or space

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[093236]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060530 BonEcho/2.0a3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060530 BonEcho/2.0a3

When I enter the keyword or something that has space in location bar then click/middle click the "Go" button, browser cannot go to the page and just show an alert that is "The URL is not valid and cannot be loaded"

Reproducible: Always

Steps to Reproduce:
1.Enter the keyword or something that has space in location bar 
2.Click/Middle click the "Go" button
3.

Actual Results:  
Browser cannot go to the page and just show an alert that is "The URL is not valid and cannot be loaded"

Expected Results:  
Go to the page that using the keyword or search the word of the website that you have type

Comment 1

[Ria Klaassen (not reading all bugmail)]

Regression between 1.9a1_2006052901 and 1.9a1_2006052912.

Comment 2

[Mike Connor [:mconnor]]

gah, right, that'll sting a little.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This makes openUILink take a third arg for allowFixup (without affecting any existing callers that omit it), and makes the allowFixup parameter to openUILinkIn work for the "current" case.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 223858 [details] [diff] [review]
patch

keyword search still don't work with this

Comment 5

[:Gavin Sharp [email: [e-mail]]]

*** Bug 340703 has been marked as a duplicate of this bug. ***

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I couldn't help doing a bit of cleanup, I tried to restrict myself to the stuff I was touching :). This patch:
- Lets handleURLBarCommand handle the go button and location bar events
- Uses openUILinkIn for mouse events, and the BrowserLoadURL for key events (as before)
- Adds some optional parameters to openUILink to make it handle bookmark keywords with postData and keyword.url fixup

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 226474 [details] [diff] [review]
patch


>-  }
>-  else  
>+  } else
>     loadURI(url, null, aPostData, true /* allow third party fixup */);
>+

we're moving to the old style, don't change this :P

>-function openUILinkIn( url, where, allowThirdPartyFixup )
>+function openUILinkIn( url, where, allowThirdPartyFixup, postData )
> {
>-  if (!where)
>+  if (!where || !url)
>     return;
> 
>-  if ((url == null) || (url == "")) 
>-    return;
>   // xlate the URL if necessary
>-  if (url.indexOf("urn:") == 0) {
>-      url = xlateURL(url);        // does RDF urn expansion
>-  }
>+  if (url.indexOf("urn:") == 0)
>+    url = xlateURL(url);        // does RDF urn expansion
>+
>   // avoid loading "", since this loads a directory listing
>-  if (url == "") {
>-      url = "about:blank";
>-  }
>+  if (url == "")
>+    url = "about:blank";

you'll never hit this if url == ""  I love that the old code explicitly checked this earlier and returned

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: for checkin

Discussed this with mconnor on IRC, turns out xlateURL isn't even defined, so I just removed that entire block.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/utilityOverlay.js 	1.38
mozilla/browser/base/content/browser.xul 	1.310
mozilla/browser/base/content/browser.js 	1.652

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 227085 [details] [diff] [review]
for checkin

This fixes a regression from bug 279687, which landed on the branch. The only change in behavior that it introduces is for clicks on the Go button, so the chance that it will cause a regression is relatively low.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.479.2.157
mozilla/browser/base/content/browser.xul 	1.268.2.46
mozilla/browser/base/content/utilityOverlay.js 	1.32.2.8

Comment 12

[Carsten Book [:Tomcat]]

v. verfied fixed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b2) Gecko/20060829 BonEcho/2.0b2