339717 - add 8-bit alpha support to Carbon icon decoder

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Josh Aas]

We need to add 8-bit alpha support to the Carbon icon decoder since we can't use the Cocoa decoder in Carbon builds (Firefox 2).

Comment 1

[Josh Aas]

Attachment: fix v1.0

This is a really conservative way to fix this. I have some other less conservative fixes in the works from messing around with this, but I'm not sure we really need to do more. Just posting this here for comments now.

Comment 2

[Josh Aas]

Oh, to explain the conservative fix. We do everything exactly the same, but if the icon data we get is non-indexed 32-bit data (which it almost always is) then we copy make the alpha 8-bit and copy the alpha data from the 32-bit icon data. If that is not the case then absolutely nothing has changed.

Comment 3

[Josh Aas]

Attachment: fix v1.1

This is also conservative also, but it gets the 8-bit mask resource instead of grabbing the 8-bit mask from 32-bit icon data.

Comment 4

[Mark Mentovai]

Comment on attachment 223840 [details] [diff] [review]
fix v1.1

We can go with this now.  Keep in mind the stuff I suggested about icns files that don't include the exact icon size we ask for.  The Cocoa decoder did scaling automatically, this decoder won't handle that.

Comment 5

[Josh Aas]

Right, but that is a separate bug not related to the fact that we don't support 8 bit alpha. I'll file it later today.

Comment 6

[Josh Aas]

checked in on trunk and 1.8.1 branch