339822 - [FIX]A principal's URIs should be immutable

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Right now, the URIs of a principal are not guaranteed immutable.  They should be.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

This uses an API I'm adding in bug 336699

Comment 3

[Darin Fisher]

Comment on attachment 223934 [details] [diff] [review]
Patch

i wonder if we should be worried about the additional perf overhead of the NS_EnsureSafeToReturn calls.  if we can make mURI immutable, then we shouldn't need to anything more than just AddRef it, but here we are adding a call to check if it is immutable each time we try to get it.

Comment 4

[Boris Zbarsky [:bzbarsky]]

I _think_ getting the URI from a principal is not on any too-critical paths.  But yeah, if it turns out it's a problem we may have to store a local boolean as to whether NS_TryToSetImmutable succeeded or something.

Other than that, the only way faster than what we do now (QI plus call) would be to store some out-of-band state in a member, or store some object that's an "nsIURI plus whether we set it immutable" or something. :(

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to final patch from bug 336699

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 223948 [details] [diff] [review]
Updated to final patch from bug 336699

r=dveditz

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.