339925 - Search window leaks (SearchDialog.js); and in <subscribe.js>

Status: NEW

(MailNews Core :: Search, defect)

Description

[Adam Guthrie]

Found using dbaron's Leak Monitor extension.

Steps to reproduce:
1. Install the extension.
2. Edit > Find > Search Messages
3. Click Search (this is to instantiate some values so we can see what they are when it leaks).
4. Close the dialog.

Results:
The following objects are leaked:
[ ] [leaked object] (8b26100) = [object Object]
[+] [leaked object] (8a6e7e0) = [object Object]
 [ ] statusTextFld (8ad9be0) = [object XULElement @ 0x8cbb408 (native @ 0x8c47658)]
 [ ] statusBar (8ad9b50) = [object XULElement @ 0x8c922d0 (native @ 0x8b56f60)]
 [ ] throbber = null
 [ ] stopCmd = null
 [ ] progressMeterContainer (8ad9b60) = [object XULElement @ 0x8bc3400 (native @ 0x8c476d8)]
 [ ] meteorsSpinning = false
 [ ] startTimeoutID = null
 [ ] progressMeterVisible = false
 [ ] myDefaultStatus = 
 [ ] stopTimeoutID = null

Expected results:
No leak.

Comment 1

[Adam Guthrie]

Some investigation...

We create our own nsMsgStatusFeedback here (the object that's leaking): http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/base/search/resources/content/SearchDialog.js&rev=1.99&mark=56#50
then set msgWindow's statusFeedback member to it here: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/base/search/resources/content/SearchDialog.js&rev=1.99&mark=320#310

I tried nulling out gStatusFeedback in the searchOnUnload function, but this didn't work. It seems like we want to be getting msgWindow's statusFeedback instread of creating our own and making msgWindow's point to it, I could be wrong, though.

FWIW, the same problem occurs in subscribe.js.

Comment 2

[Adam Hauner]

Dupe of bug 339784?

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Dupe of bug 339784?

Yes, the <SearchDialog.js> part is (duplicate of) bug 339784.