Remove hidden window from accessibility hierarchy

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: hwaara, Assigned: hwaara)

Tracking

(Blocks: 1 bug)

Trunk
PowerPC
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 obsolete attachments)

(Assignee)

Description

12 years ago
The hidden window shouldn't show up for third parties. 

An easy way to test is to use the tool "Accessibility Verifier" that ships with XCode, where the hidden window shows up and is inspectable.
(Assignee)

Comment 1

12 years ago
Created attachment 224069 [details] [diff] [review]
Fix v1

The fix is to create a subclass for our hidden window, that will always be ignored for accessibility.

The hidden window's ChildView also checks to see if it's inside the hidden window.
Attachment #224069 - Flags: review?(joshmoz)
(Assignee)

Comment 2

12 years ago
Comment on attachment 224069 [details] [diff] [review]
Fix v1

Actually, currently our ChildViews are always ignored for accessibility. 

We should stay that way for now (until I teach gecko how to understand their contents and make them visible).
Attachment #224069 - Attachment is obsolete: true
Attachment #224069 - Flags: review?(joshmoz)
(Assignee)

Comment 3

12 years ago
Created attachment 224073 [details] [diff] [review]
Fix v2

More comments, and don't make ChildViews unignored (yet).
Attachment #224073 - Flags: review?(joshmoz)
(Assignee)

Comment 4

12 years ago
Josh said this will have to go in after sheets, so making a dependency.
Depends on: 330587

Comment 5

12 years ago
Comment on attachment 224073 [details] [diff] [review]
Fix v2

drop the funny characters bt "TODO"
Attachment #224073 - Flags: review?(mark)
Attachment #224073 - Flags: review?(joshmoz)
Attachment #224073 - Flags: review+
(Assignee)

Comment 6

12 years ago
Comment on attachment 224073 [details] [diff] [review]
Fix v2

This patch is now obsolete because I've come a long way past this now, and will have a slightly broader approach.

I'll post a bigger patch in another bug later when I have it working.
Attachment #224073 - Attachment is obsolete: true
Attachment #224073 - Flags: review?(mark)
(Assignee)

Updated

12 years ago
Blocks: 342989
(Assignee)

Comment 7

12 years ago
Fixed along with bug 342146.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.