339965 - Remove hidden window from accessibility hierarchy

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Håkan Waara]

The hidden window shouldn't show up for third parties. 

An easy way to test is to use the tool "Accessibility Verifier" that ships with XCode, where the hidden window shows up and is inspectable.

Comment 1

[Håkan Waara]

Attachment: Fix v1

The fix is to create a subclass for our hidden window, that will always be ignored for accessibility.

The hidden window's ChildView also checks to see if it's inside the hidden window.

Comment 2

[Håkan Waara]

Comment on attachment 224069 [details] [diff] [review]
Fix v1

Actually, currently our ChildViews are always ignored for accessibility. 

We should stay that way for now (until I teach gecko how to understand their contents and make them visible).

Comment 3

[Håkan Waara]

Attachment: Fix v2

More comments, and don't make ChildViews unignored (yet).

Comment 4

[Håkan Waara]

Josh said this will have to go in after sheets, so making a dependency.

Comment 5

[Josh Aas]

Comment on attachment 224073 [details] [diff] [review]
Fix v2

drop the funny characters bt "TODO"

Comment 6

[Håkan Waara]

Comment on attachment 224073 [details] [diff] [review]
Fix v2

This patch is now obsolete because I've come a long way past this now, and will have a slightly broader approach.

I'll post a bigger patch in another bug later when I have it working.

Comment 7

[Håkan Waara]

Fixed along with bug 342146.