340006 - general.startup.* prefs don't work for mailnews items in suiterunner

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Mark Banner (:standard8)]

Bug 335550 implemented a default commandline handler for suiterunner. Part of this was to handle the general.startup.* prefs. However some of these work:

general.startup.chat
general.startup.browser
general.startup.editor

but most of them won't:

general.startup.addressbook
general.startup.mail
general.startup.calendar
general.startup.news
general.startup.compose

The problem is that the contract id to try to startup these items is defined as:

@mozilla.org/commandlinehandler/general-startup;1?type=

plus the end of the pref name. For xpfe SeaMonkey this is fine, as the mailnews items use the old commandlinehander and define the contract ids as above. For the new suiterunner, this doesn't work, the contact ids appear to now be as follows:

general.startup.addressbook - @mozilla.org/addressbook;1
general.startup.mail - @mozilla.org/appshell/component/messenger;1
general.startup.news - @mozilla.org/messenger/nntpservice;1
general.startup.compose - @mozilla.org/messengercompose;1

What a nice mixture ;-)

I couldn't quite work out a relevant one for calendar - that's if we still want to support it as it currently stands.

Comment 1

[[e-mail]]

Attachment: Compiles, but untested as yet

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> Created an attachment (id=224194) [edit]
> Compiles, but untested as yet
> 

This doesn't seem to work, at least for address book anyway.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Note: this doesn't work with the general.startup.mail preference yet but that's unrelated to this patch as the -mail command line argument doesn't work either.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 224265 [details] [diff] [review]
Proposed patch

Looks good to me.

Comment 5

[[e-mail]]

Comment on attachment 224265 [details] [diff] [review]
Proposed patch

Asking David for sr as I hear Scott is on holiday(?)

Comment 6

[[e-mail]]

Fix checked in.