340017 - document.formName doesn't work in XHTML

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Splitting from bug 339944 and from bug 109373 (which was marked as a dup of bug 111514).

Loading the testcase should do a Google search for "whee".  Instead, it says document.formName is undefined.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060525 Minefield/3.0a1

Comment 1

[Jesse Ruderman]

Attachment: testcase (XHTML)

Comment 2

[Jesse Ruderman]

Attachment: testcase (HTML) for comparison

Comment 3

[Boris Zbarsky [:bzbarsky]]

Does it work if you do it from onload?

Comment 4

[Jesse Ruderman]

It doesn't work if I put "javascript:alert(document.frmAuto)" in the address bar.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Ah, ok.  So it looks like this is purposeful.  See

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/html/document/src/nsHTMLDocument.cpp&rev=3.680&mark=3329-3333#3323

for the relevant code.

Comment 6

[Jesse Ruderman]

HTML5 says:

"When the HTMLDocument object is indexed for property retrieval using a name name, then the user agent must return the value obtained using the following steps..."

and:

"All Document objects (in user agents implementing this specification) must also implement the HTMLDocument interface, available using binding-specific methods. (This is the case whether or not the document in question is an HTML document or indeed whether it contains any HTML elements at all.)"

Comment 7

[Saint Wesonga]

Attachment: Patch

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 408252 [details] [diff] [review]
Patch

r=bzbarsky.  My apologies for the lag here...

Comment 9

[Boris Zbarsky [:bzbarsky]]

I'll push the patch once the tree reopens.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/9a8561e57279

Thank you again for the patch!