340119 - [FIX]Changing print preview settings makes <noscript> tags appear

Status: VERIFIED FIXED

Description

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

See bug 334944 comment 20.

At a guess, someone somewhere is calling TurnScriptingOn _again_ on every single change.  It's not clear whether the right fix is to change that inane behavior or to change TurnScriptingOn to work around it.

Comment 1

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

OK, the print preview UI is just on complete crack and runs PrintPreview() every single time something changes.  Without tearing down the old preview, from what I can see.

I guess we get to work around this in TurnScriptingOn... :(

Comment 2

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

Created attachment 224204 [details] [diff] [review]
Maybe this will make life better?

Comment 3

[Doron Rosenberg (IBM)]

tested on trunk windows firefox debug and this fixed the testcase for me.

Comment 4

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

Comment on attachment 224204 [details] [diff] [review]
Maybe this will make life better?

sicking, could you review?

Comment 5

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

Created attachment 224207 [details] [diff] [review]
1.8 branch version

Comment 6

[Tracy Walker [:tracy]]

*** Bug 340145 has been marked as a duplicate of this bug. ***

Comment 7

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

Fixed on trunk and 1.8 branch.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 224207 [details] [diff] [review]
1.8 branch version

approved for 1.8.0 branch, a=dveditz for drivers

Comment 9

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

Fixed on the 1.8.0 branch.

Comment 10

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060612 BonEcho/2.0a3