[FIX]Changing print preview settings makes <noscript> tags appear

VERIFIED FIXED in mozilla1.9alpha1

Status

()

Core
Print Preview
P1
normal
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

({fixed1.8.0.5, fixed1.8.1})

Trunk
mozilla1.9alpha1
x86
All
fixed1.8.0.5, fixed1.8.1
Points:
---
Bug Flags:
blocking1.8.0.5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

See bug 334944 comment 20.

At a guess, someone somewhere is calling TurnScriptingOn _again_ on every single change.  It's not clear whether the right fix is to change that inane behavior or to change TurnScriptingOn to work around it.
OK, the print preview UI is just on complete crack and runs PrintPreview() every single time something changes.  Without tearing down the old preview, from what I can see.

I guess we get to work around this in TurnScriptingOn... :(
Created attachment 224204 [details] [diff] [review]
Maybe this will make life better?

Comment 3

11 years ago
tested on trunk windows firefox debug and this fixed the testcase for me.
Comment on attachment 224204 [details] [diff] [review]
Maybe this will make life better?

sicking, could you review?
Attachment #224204 - Flags: superreview?(bugmail)
Attachment #224204 - Flags: review?(bugmail)
Created attachment 224207 [details] [diff] [review]
1.8 branch version
Assignee: printing → bzbarsky
Status: NEW → ASSIGNED
Attachment #224207 - Flags: approval1.8.0.5?
Attachment #224207 - Flags: approval-branch-1.8.1?(bugmail)
Flags: blocking1.8.0.5?
Priority: -- → P1
Summary: Changing print preview settings makes <noscript> tags appear → [FIX]Changing print preview settings makes <noscript> tags appear
Target Milestone: --- → mozilla1.9alpha

Updated

11 years ago
OS: Linux → All

Comment 6

11 years ago
*** Bug 340145 has been marked as a duplicate of this bug. ***
Attachment #224204 - Flags: superreview?(bugmail)
Attachment #224204 - Flags: superreview+
Attachment #224204 - Flags: review?(bugmail)
Attachment #224204 - Flags: review+
Attachment #224207 - Flags: approval-branch-1.8.1?(bugmail) → approval-branch-1.8.1+
Fixed on trunk and 1.8 branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Flags: blocking1.8.0.5? → blocking1.8.0.5+
Comment on attachment 224207 [details] [diff] [review]
1.8 branch version

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #224207 - Flags: approval1.8.0.5? → approval1.8.0.5+
Fixed on the 1.8.0 branch.
Keywords: fixed1.8.0.5
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060612 BonEcho/2.0a3
Status: RESOLVED → VERIFIED
Blocks: 342439
You need to log in before you can comment on or make changes to this bug.