Closed
Bug 340119
Opened 15 years ago
Closed 15 years ago
[FIX]Changing print preview settings makes <noscript> tags appear
Categories
(Core :: Print Preview, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla1.9alpha1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: fixed1.8.0.5, fixed1.8.1)
Attachments
(2 files)
2.46 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
2.46 KB,
patch
|
sicking
:
approval-branch-1.8.1+
dveditz
:
approval1.8.0.5+
|
Details | Diff | Splinter Review |
See bug 334944 comment 20. At a guess, someone somewhere is calling TurnScriptingOn _again_ on every single change. It's not clear whether the right fix is to change that inane behavior or to change TurnScriptingOn to work around it.
![]() |
Assignee | |
Comment 1•15 years ago
|
||
OK, the print preview UI is just on complete crack and runs PrintPreview() every single time something changes. Without tearing down the old preview, from what I can see. I guess we get to work around this in TurnScriptingOn... :(
![]() |
Assignee | |
Comment 2•15 years ago
|
||
Comment 3•15 years ago
|
||
tested on trunk windows firefox debug and this fixed the testcase for me.
![]() |
Assignee | |
Comment 4•15 years ago
|
||
Comment on attachment 224204 [details] [diff] [review] Maybe this will make life better? sicking, could you review?
Attachment #224204 -
Flags: superreview?(bugmail)
Attachment #224204 -
Flags: review?(bugmail)
![]() |
Assignee | |
Comment 5•15 years ago
|
||
Assignee: printing → bzbarsky
Status: NEW → ASSIGNED
Attachment #224207 -
Flags: approval1.8.0.5?
Attachment #224207 -
Flags: approval-branch-1.8.1?(bugmail)
![]() |
Assignee | |
Updated•15 years ago
|
Flags: blocking1.8.0.5?
Priority: -- → P1
Summary: Changing print preview settings makes <noscript> tags appear → [FIX]Changing print preview settings makes <noscript> tags appear
Target Milestone: --- → mozilla1.9alpha
Updated•15 years ago
|
OS: Linux → All
Comment 6•15 years ago
|
||
*** Bug 340145 has been marked as a duplicate of this bug. ***
Attachment #224204 -
Flags: superreview?(bugmail)
Attachment #224204 -
Flags: superreview+
Attachment #224204 -
Flags: review?(bugmail)
Attachment #224204 -
Flags: review+
Attachment #224207 -
Flags: approval-branch-1.8.1?(bugmail) → approval-branch-1.8.1+
![]() |
Assignee | |
Comment 7•15 years ago
|
||
Fixed on trunk and 1.8 branch.
Updated•15 years ago
|
Flags: blocking1.8.0.5? → blocking1.8.0.5+
Comment 8•15 years ago
|
||
Comment on attachment 224207 [details] [diff] [review] 1.8 branch version approved for 1.8.0 branch, a=dveditz for drivers
Attachment #224207 -
Flags: approval1.8.0.5? → approval1.8.0.5+
![]() |
Assignee | |
Comment 9•15 years ago
|
||
Fixed on the 1.8.0 branch.
![]() |
Assignee | |
Updated•15 years ago
|
Keywords: fixed1.8.0.5
Comment 10•15 years ago
|
||
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060612 BonEcho/2.0a3
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•