340233 - -inspector doesn't work

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[[e-mail]]

There are two bugs in -inspector
1. It opens the window without any args, so it's not resizable
2. It doesn't prevent the default command line action

Was there a reason why toolkit was changed to use -inspect <url>?

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Alex Vincent [:WeirdAl]]

Comment on attachment 224377 [details] [diff] [review]
Proposed patch

>+      if (uristr == null)

if (!uristr)

Maybe?

Comment 3

[[e-mail]]

(In reply to comment #2)
>(From update of attachment 224377 [details] [diff] [review] [edit])
>>+      if (uristr == null)
>if (!uristr)
>Maybe?
Sadly not. The API sucks; the return values are
(no flag) returns null (flag) throws (flag with value) returns the value
So -inspector "" returns an empty string, which would "fail" your test.

Comment 4

[[e-mail]]

Fix checked in.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 224377 [details] [diff] [review]
Proposed patch

It would be great if we could get this on the branch. The non-resizable problem is tough for novice XULRunner developers to get around.

Comment 6

[Darin Fisher]

Comment on attachment 224377 [details] [diff] [review]
Proposed patch

a=darin on behalf of drivers (please land this on the MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword to this bug)

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed on branch.

Comment 8

[[e-mail]]

It's courteous to allow the original patch author time to check his patch in.

It's also not a good idea to check in a -w version of a patch.

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #8)
> It's courteous to allow the original patch author time to check his patch in.
> 
> It's also not a good idea to check in a -w version of a patch.
> 

Gah! Sorry! What would you like me to do?

Comment 10

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Whitespace fix

Whitespace fix from attachment 224377 [details] [diff] [review].

Comment 11

[[e-mail]]

Comment on attachment 226854 [details] [diff] [review]
Whitespace fix

>+    var wwatch = Components.classes["@mozilla.org/embedcomp/window-watcher;1"]
>+                            .getService(nsIWindowWatcher);
You're not having much luck, ^^ are you? r=me with this fixed.

Comment 12

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Whitespace fix

(In reply to comment #11)
> You're not having much luck, ^^ are you? r=me with this fixed.

Yikes. What a day.

Comment 13

[Darin Fisher]

Comment on attachment 226866 [details] [diff] [review]
Whitespace fix

a=darin on behalf of drivers

Comment 14

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 226866 [details] [diff] [review]
Whitespace fix

Neil, I'm betting you want me to check this in? Just let me know.

Comment 15

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Checked in the whitespace fix.