Closed Bug 340233 Opened 18 years ago Closed 18 years ago

-inspector doesn't work

Categories

(Other Applications :: DOM Inspector, defect)

Product:
Other Applications
Component:
DOM Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 1 obsolete file)

Proposed patch
1.75 KB, patch
timeless
: review+
darin.moz
: approval1.8.1+
Details | Diff | Splinter Review
Whitespace fix
1.11 KB, patch
darin.moz
: approval1.8.1+
Details | Diff | Splinter Review 
There are two bugs in -inspector
1. It opens the window without any args, so it's not resizable
2. It doesn't prevent the default command line action

Was there a reason why toolkit was changed to use -inspect <url>?
Blocks: 276588
Flags: blocking1.9a2?
Attached patch Proposed patch — — Splinter Review 
Assignee: dom-inspector → neil
Status: NEW → ASSIGNED

        Attachment #224377 -
        Flags: review?(timeless)

    
    

    
  
Comment on attachment 224377 [details] [diff] [review]
Proposed patch

>+      if (uristr == null)

if (!uristr)

Maybe?

    
    

    
  
(In reply to comment #2)
>(From update of attachment 224377 [details] [diff] [review] [edit])
>>+      if (uristr == null)
>if (!uristr)
>Maybe?
Sadly not. The API sucks; the return values are
(no flag) returns null (flag) throws (flag with value) returns the value
So -inspector "" returns an empty string, which would "fail" your test.

    
  

        Attachment #224377 -
        Flags: review?(timeless) → review+

    
    

    
  
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 224377 [details] [diff] [review]
Proposed patch

It would be great if we could get this on the branch. The non-resizable problem is tough for novice XULRunner developers to get around.

        Attachment #224377 -
        Flags: approval1.8.1?

    
    

    
  
Comment on attachment 224377 [details] [diff] [review]
Proposed patch

a=darin on behalf of drivers (please land this on the MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword to this bug)

        Attachment #224377 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
It's courteous to allow the original patch author time to check his patch in.

It's also not a good idea to check in a -w version of a patch.

    
    

    
  
(In reply to comment #8)
> It's courteous to allow the original patch author time to check his patch in.
> 
> It's also not a good idea to check in a -w version of a patch.
> 

Gah! Sorry! What would you like me to do?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Whitespace fix (obsolete)
        — 
          — Splinter Review
      

    


  
Whitespace fix from attachment 224377 [details] [diff] [review].

        Attachment #226854 -
        Flags: review?(neil)

        Attachment #226854 -
        Flags: approval1.8.1?

    
    

    
  
Comment on attachment 226854 [details] [diff] [review]
Whitespace fix

>+    var wwatch = Components.classes["@mozilla.org/embedcomp/window-watcher;1"]
>+                            .getService(nsIWindowWatcher);
You're not having much luck, ^^ are you? r=me with this fixed.

        Attachment #226854 -
        Flags: review?(neil) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Whitespace fix
        — 
          — Splinter Review
      

    


  
(In reply to comment #11)
> You're not having much luck, ^^ are you? r=me with this fixed.

Yikes. What a day.

        Attachment #226854 -
        Attachment is obsolete: true

        Attachment #226866 -
        Flags: approval1.8.1?

        Attachment #226854 -
        Flags: approval1.8.1?

    
    

    
  
Comment on attachment 226866 [details] [diff] [review]
Whitespace fix

a=darin on behalf of drivers

        Attachment #226866 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
Comment on attachment 226866 [details] [diff] [review]
Whitespace fix

Neil, I'm betting you want me to check this in? Just let me know.

    
    

    
  
Checked in the whitespace fix.
Flags: blocking1.9a2?

    
  
QA Contact: timeless → dom-inspector

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: